From: Jonas Bonn <jonas@southpole.se>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
jgarzik@pobox.com, Greg KH <greg@kroah.com>
Subject: Re: [PATCH] net: use DECLARE_PCI_DEVICE_TABLE
Date: Fri, 07 Mar 2008 08:58:54 +0100 [thread overview]
Message-ID: <47D0F5BE.7010909@southpole.se> (raw)
In-Reply-To: <20080306154150.0ba906fa.akpm@linux-foundation.org>
Andrew Morton wrote:
> Bah.
>
> a) DECLARE_PCI_DEVICE_TABLE is misnamed. It is used to *define* tables,
> not to declare them. It should be called DEFINE_PCI_DEVICE_TABLE.
>
Fair enough...
> b) It's lame, anyway. We could implement any number of such helper
> thingies, but we choose not to.
>
When I originally proposed these cleanups, I posted opened-coded
versions. That was deemed to be ugly and using a macro was suggested.
So now I've reworked this with a macro, and now the macro is being
deemed to be ugly, too!
The point of this exercise wasn't really to do a macro at all; the point
was to get these structures marked 'const' and into __devinitconst
where they belong. Whether the open-coded approach or the macro is the
way to go, is all the same to me; any guidance on how to proceed would
be appreciated.
next prev parent reply other threads:[~2008-03-07 7:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 10:55 struct pci_device_id declaration cleanups Jonas Bonn
2008-03-06 10:55 ` [PATCH] net: use DECLARE_PCI_DEVICE_TABLE Jonas Bonn
2008-03-06 10:55 ` Jonas Bonn
2008-03-06 10:55 ` Jonas Bonn
2008-03-06 10:55 ` Jonas Bonn
2008-03-06 10:55 ` Jonas Bonn
2008-03-06 10:55 ` Jonas Bonn
2008-03-06 10:55 ` Jonas Bonn
2008-03-06 10:55 ` Jonas Bonn
2008-03-06 10:55 ` Jonas Bonn
2008-03-06 23:41 ` Andrew Morton
2008-03-07 0:18 ` David Miller
2008-03-07 7:58 ` Jonas Bonn [this message]
2008-03-06 12:25 ` struct pci_device_id declaration cleanups Christoph Hellwig
2008-03-06 12:36 ` Jonas Bonn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D0F5BE.7010909@southpole.se \
--to=jonas@southpole.se \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).