From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 2.6.25] - Fix transmit queue stop mechanism Date: Mon, 17 Mar 2008 08:09:25 -0400 Message-ID: <47DE5F75.4030700@garzik.org> References: <20080313071330.10331.66058.stgit@speedy5> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, swise@opengridcomputing.com To: Divy Le Ray Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:52337 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752850AbYCQMJ1 (ORCPT ); Mon, 17 Mar 2008 08:09:27 -0400 In-Reply-To: <20080313071330.10331.66058.stgit@speedy5> Sender: netdev-owner@vger.kernel.org List-ID: Divy Le Ray wrote: > From: Divy Le Ray > > The last change in the Tx queue stop mechanism opens a window > where the Tx queue might be stopped after pending credits > returned. > > Tx credits are returned via a control message generated by the HW. > It returns tx credits on demand, triggered by a completion bit > set in selective transmit packet headers. > > The current code can lead to the Tx queue stopped > with all pending credits returned, and the current frame > not triggering a credit return. The Tx queue will then never be > awaken. > > The driver could alternatively request a completion for packets > that stop the queue. It's however safer at this point to go back > to the pre-existing behaviour. > > Signed-off-by: Divy Le Ray > --- > > drivers/net/cxgb3/sge.c | 12 +++++++++--- > 1 files changed, 9 insertions(+), 3 deletions(-) applied -- please include "cxgb3: " prefix in your subject line next time. See http://linux.yyz.us/patch-format.html for more info. Jeff