From: Patrick McHardy <kaber@trash.net>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Pavel Emelyanov <xemul@openvz.org>,
Phil Oester <kernel@linuxace.com>,
netdev@vger.kernel.org
Subject: Re: 2.6.25-rc: Null dereference in ip_defrag
Date: Mon, 17 Mar 2008 18:51:57 +0100 [thread overview]
Message-ID: <47DEAFBD.5030603@trash.net> (raw)
In-Reply-To: <1205776662.27115.1.camel@iris.sw.ru>
Denis V. Lunev wrote:
> On Mon, 2008-03-17 at 18:43 +0100, Patrick McHardy wrote:
>> Pavel Emelyanov wrote:
>>
>> > Can you check with this patch, please (untested, but should work)?
>>
>> This is getting pretty ugly. Shouldn't
>>
>> int ip_defrag(struct sk_buff *skb, u32 user)
>> {
>> ...
>> - net = skb->dev->nd_net;
>> + net = skb->dev ? skb->dev->nd_net : skb->dst->dev->nd_net;
>>From my POW the we can just get skb->dst->dev. Could we?
>
> I think that on IP level dealing with fragments we always have the
> destination entry. I'll recheck this tomorrow.
Unfortunately no, on the receive path connection tracking
will call ip_defrag before routing took place.
next prev parent reply other threads:[~2008-03-17 18:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-17 17:00 2.6.25-rc: Null dereference in ip_defrag Phil Oester
2008-03-17 17:40 ` Pavel Emelyanov
2008-03-17 17:43 ` Patrick McHardy
2008-03-17 17:57 ` Denis V. Lunev
2008-03-17 17:51 ` Patrick McHardy [this message]
2008-03-17 19:40 ` Phil Oester
2008-03-18 7:53 ` Pavel Emelyanov
2008-03-18 9:51 ` Pavel Emelyanov
2008-03-20 0:39 ` Phil Oester
2008-03-20 14:47 ` Patrick McHardy
2008-03-20 15:30 ` Phil Oester
2008-03-20 15:33 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47DEAFBD.5030603@trash.net \
--to=kaber@trash.net \
--cc=den@openvz.org \
--cc=kernel@linuxace.com \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).