netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Joe Perches <joe@perches.com>
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	John Ronciak <john.ronciak@intel.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH 6/6] drivers/net/e1000 - Convert int32_t to s32
Date: Wed, 19 Mar 2008 14:03:58 -0700	[thread overview]
Message-ID: <47E17FBE.4010800@intel.com> (raw)
In-Reply-To: <c18867835e6cd98fe94fa418abf7f2432a7786a5.1205779102.git.joe@perches.com>

Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  drivers/net/e1000/e1000_hw.c   |  486 ++++++++++++++++++++--------------------
>  drivers/net/e1000/e1000_hw.h   |   58 +++---
>  drivers/net/e1000/e1000_main.c |    4 +-
>  3 files changed, 274 insertions(+), 274 deletions(-)


can you do all the 4 conversions in a single patch? most of these hunks are now
quadrupled into patches (they all touch the same parts of the files mostly), and
that doesn't improve git-blame output nor reviewability.

so just one patch for ixgb and one patch for e1000 should suffice, instead of 4
for each driver :)

thanks Joe

Auke

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  parent reply	other threads:[~2008-03-19 21:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-18 16:13 [PATCH 1/6] drivers/net/e1000 - Convert u_int8_t to u8 Joe Perches
2008-03-18 16:13 ` [PATCH 2/6] drivers/net/e1000 - Convert u_int16_t to u16 Joe Perches
2008-03-18 16:13 ` [PATCH 3/6] drivers/net/e1000 - Convert u_int32_t to u32 Joe Perches
2008-03-18 16:13 ` [PATCH 4/6] drivers/net/e1000 - Convert u_int64_t to u64 Joe Perches
2008-03-18 16:13 ` [PATCH 5/6] drivers/net/e1000 - Convert int16_t to s16 Joe Perches
2008-03-18 16:13 ` [PATCH 6/6] drivers/net/e1000 - Convert int32_t to s32 Joe Perches
2008-03-18 16:13   ` [PATCH 07/10] drivers/net/ixgb - Convert u_int8_t to u8 Joe Perches
2008-03-18 16:13     ` [PATCH 08/10] drivers/net/ixgb - Convert u_int16_t to u16 Joe Perches
2008-03-18 16:13     ` [PATCH 09/10] drivers/net/ixgb - Convert u_int32_t to u32 Joe Perches
2008-03-18 16:13     ` [PATCH 10/10] drivers/net/ixgb - Convert u_int64_t to u64 Joe Perches
2008-03-19 21:03   ` Kok, Auke [this message]
2008-03-19 21:49     ` [PATCH 6/6] drivers/net/e1000 - Convert int32_t to s32 Joe Perches
2008-03-19 22:14       ` Kok, Auke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47E17FBE.4010800@intel.com \
    --to=auke-jan.h.kok@intel.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=jgarzik@pobox.com \
    --cc=joe@perches.com \
    --cc=john.ronciak@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).