From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roel Kluin <12o3l@tiscali.nl> Subject: drivers/net/niu.c: memcpy(dev->dev_addr, dev->perm_addr, dev->addr_len)? Date: Thu, 20 Mar 2008 22:01:27 +0100 Message-ID: <47E2D0A7.9050608@tiscali.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: "David S. Miller" Return-path: Received: from smtp-out1.tiscali.nl ([195.241.79.176]:58029 "EHLO smtp-out1.tiscali.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755340AbYCTVB3 (ORCPT ); Thu, 20 Mar 2008 17:01:29 -0400 Sender: netdev-owner@vger.kernel.org List-ID: in drivers/net/niu.c, line 6406, 6286 and 7173: memcpy(dev->dev_addr, dev->perm_addr, dev->addr_len); I noticed that " memcpy(dev->perm_addr, dev->dev_addr, dev->addr_len) occurs much more often (15x). could it be that the first two arguments are swapped in niu.c?