From: Jeff Garzik <jgarzik@pobox.com>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/4] bonding: Fix locking in 802.3ad mode
Date: Tue, 25 Mar 2008 23:18:18 -0400 [thread overview]
Message-ID: <47E9C07A.1040208@pobox.com> (raw)
In-Reply-To: <1206163777364-git-send-email-fubar@us.ibm.com>
Jay Vosburgh wrote:
> The 802.3ad state machine lock can be acquired in both softirq and
> not softirq context, but was not held at _bh to prevent a deadlock (which
> could occur if a LACPDU arrived and was processed while the lock was
> held).
>
> Corrected this, now hold the state machine lock at _bh to prevent
> deadlock.
>
> Bug reported by Todd Fleisher <todd@fleish.org>.
>
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
> ---
> drivers/net/bonding/bond_3ad.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
applied 1-4
prev parent reply other threads:[~2008-03-26 3:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-22 5:29 [PATCH 0/4] bonding: fixes for 2.6.25 Jay Vosburgh
2008-03-22 5:29 ` [PATCH 1/4] bonding: Fix locking in 802.3ad mode Jay Vosburgh
2008-03-22 5:29 ` [PATCH 2/4] bonding: fix two compiler warnings Jay Vosburgh
2008-03-22 5:29 ` [PATCH 3/4] bonding: Fix sysfs attribute handling Jay Vosburgh
2008-03-22 5:29 ` [PATCH 4/4] bonding: update version Jay Vosburgh
2008-03-26 3:18 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E9C07A.1040208@pobox.com \
--to=jgarzik@pobox.com \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).