* [PATCH] b44: Truncate PHY address
@ 2008-03-25 17:04 Michael Buesch
2008-03-26 3:20 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Michael Buesch @ 2008-03-25 17:04 UTC (permalink / raw)
To: Jeff Garzik; +Cc: agb, Gary Zambrano, netdev
Some ROMs on embedded devices store incorrect values for
the PHY address of the ethernet device.
It looks like the number is sign-extended.
Truncate the value by applying the PHY-address mask to it.
The patch was tested on a bcm47xx embedded system (where the bug
triggers) and a bcm4400 PCI card.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
---
Jeff, this is a bugfix for 2.6.25.
Index: wireless-testing/drivers/net/b44.c
===================================================================
--- wireless-testing.orig/drivers/net/b44.c 2008-02-16 19:08:12.000000000 +0100
+++ wireless-testing/drivers/net/b44.c 2008-03-22 01:13:21.000000000 +0100
@@ -2082,6 +2082,11 @@ static int __devinit b44_get_invariants(
addr = sdev->bus->sprom.et0mac;
bp->phy_addr = sdev->bus->sprom.et0phyaddr;
}
+ /* Some ROMs have buggy PHY addresses with the high
+ * bits set (sign extension?). Truncate them to a
+ * valid PHY address. */
+ bp->phy_addr &= 0x1F;
+
memcpy(bp->dev->dev_addr, addr, 6);
if (!is_valid_ether_addr(&bp->dev->dev_addr[0])){
--
Greetings Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] b44: Truncate PHY address
2008-03-25 17:04 [PATCH] b44: Truncate PHY address Michael Buesch
@ 2008-03-26 3:20 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-03-26 3:20 UTC (permalink / raw)
To: Michael Buesch; +Cc: agb, Gary Zambrano, netdev
Michael Buesch wrote:
> Some ROMs on embedded devices store incorrect values for
> the PHY address of the ethernet device.
> It looks like the number is sign-extended.
> Truncate the value by applying the PHY-address mask to it.
> The patch was tested on a bcm47xx embedded system (where the bug
> triggers) and a bcm4400 PCI card.
>
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
>
> ---
>
> Jeff, this is a bugfix for 2.6.25.
>
>
> Index: wireless-testing/drivers/net/b44.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/b44.c 2008-02-16 19:08:12.000000000 +0100
> +++ wireless-testing/drivers/net/b44.c 2008-03-22 01:13:21.000000000 +0100
> @@ -2082,6 +2082,11 @@ static int __devinit b44_get_invariants(
> addr = sdev->bus->sprom.et0mac;
> bp->phy_addr = sdev->bus->sprom.et0phyaddr;
> }
> + /* Some ROMs have buggy PHY addresses with the high
> + * bits set (sign extension?). Truncate them to a
> + * valid PHY address. */
> + bp->phy_addr &= 0x1F;
> +
> memcpy(bp->dev->dev_addr, addr, 6);
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-26 3:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-25 17:04 [PATCH] b44: Truncate PHY address Michael Buesch
2008-03-26 3:20 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).