From: Jeff Garzik <jeff@garzik.org>
To: Oliver Martin <oliver.martin@student.tuwien.ac.at>
Cc: netdev@vger.kernel.org, hvr@gnu.org, buytenh@wantstofly.org
Subject: Re: [PATCH] Re: ep93xx_eth PHY problems
Date: Wed, 26 Mar 2008 00:42:32 -0400 [thread overview]
Message-ID: <47E9D438.4090206@garzik.org> (raw)
In-Reply-To: <20080321202202.129c1239@ors>
Oliver Martin wrote:
> Am Tue, 04 Mar 2008 14:02:15 +0100
> schrieb Oliver Martin <oliver.martin@student.tuwien.ac.at>:
>> Now I'm having different problems: When auto-negotiation is enabled,
>> it sometimes randomly changes the link state:
>>
>> PHY: 0:01 - Link is Down
>> PHY: 0:01 - Link is Up - 100/Full
>>
>
> I've found at least one part of the problem. The MDIO clock divisor
> wasn't set again after the reset in ep93xx_start_hw. It was left at the
> default, resulting in a 12.5 MHz clock, which the PHY (Micrel KSZ8721BL)
> didn't like too much. Calling ep93xx_mdio_reset after the reset fixed
> it, the link is now perfectly stable in auto-negotiation mode.
>
> There still seems to be another bug with auto-negotiation disabled: It
> doesn't switch to 1000 Mbps any more, but most times it doesn't stay in
> the intended configuration either. I haven't done any extensive
> testing of this yet, though.
>
> Signed-off-by: Oliver Martin <oliver.martin@student.tuwien.ac.at>
ACKs from Lennert, others?
I don't know enough about the hardware to say...
Seems straightforward to me?
2.6.25 or 2.6.26 material?
Any more testing results?
next prev parent reply other threads:[~2008-03-26 4:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 13:02 ep93xx_eth PHY problems Oliver Martin
2008-03-21 19:22 ` [PATCH] " Oliver Martin
2008-03-26 4:42 ` Jeff Garzik [this message]
2008-03-29 18:13 ` Oliver Martin
2008-03-29 18:17 ` Lennert Buytenhek
2008-09-14 2:11 ` Jeff Garzik
2008-09-14 11:47 ` Lennert Buytenhek
2008-09-14 11:58 ` Herbert Valerio Riedel
2008-09-14 12:11 ` Oliver Martin
2008-09-14 12:12 ` Lennert Buytenhek
2008-09-14 12:24 ` Oliver Martin
2008-09-16 12:51 ` Lennert Buytenhek
2008-09-17 9:13 ` Oliver Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E9D438.4090206@garzik.org \
--to=jeff@garzik.org \
--cc=buytenh@wantstofly.org \
--cc=hvr@gnu.org \
--cc=netdev@vger.kernel.org \
--cc=oliver.martin@student.tuwien.ac.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).