netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Valentine Barshak <vbarshak@ru.mvista.com>
To: Olof Johansson <olof@lixom.net>
Cc: jgarzik@pobox.com, linuxppc-dev@ozlabs.org,
	pasemi-linux@ozlabs.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] pasemi_mac: Netpoll support
Date: Wed, 26 Mar 2008 15:41:01 +0300	[thread overview]
Message-ID: <47EA445D.9090509@ru.mvista.com> (raw)
In-Reply-To: <20080326015801.GC23103@lixom.net>

Olof Johansson wrote:
> Add netpoll support to allow use of netconsole.
> 
> Signed-off-by: Nate Case <ncase@xes-inc.com>
> Signed-off-by: Olof Johansson <olof@lixom.net>
> 
> diff --git a/drivers/net/pasemi_mac.c b/drivers/net/pasemi_mac.c
> index abb1dc4..6030ffe 100644
> --- a/drivers/net/pasemi_mac.c
> +++ b/drivers/net/pasemi_mac.c
> @@ -1648,6 +1648,26 @@ static int pasemi_mac_poll(struct napi_struct *napi, int budget)
>  	return pkts;
>  }
>  
> +#ifdef CONFIG_NET_POLL_CONTROLLER
> +/*
> + * Polling 'interrupt' - used by things like netconsole to send skbs
> + * without having to re-enable interrupts. It's not called while
> + * the interrupt routine is executing.
> + */
> +static void pasemi_mac_netpoll(struct net_device *dev)
> +{
> +	const struct pasemi_mac *mac = netdev_priv(dev);
> +
> +	disable_irq(mac->tx->chan.irq);
> +	pasemi_mac_tx_intr(mac->tx->chan.irq, mac->tx);
> +	enable_irq(mac->tx->chan.irq);
> +
> +	disable_irq(mac->rx->chan.irq);
> +	pasemi_mac_rx_intr(mac->rx->chan.irq, dev);

Shouldn't this actually be pasemi_mac_rx_intr(mac->rx->chan.irq, mac->rx)?
Thanks,
Valentine.

> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev


  reply	other threads:[~2008-03-26 12:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-26  1:56 [PATCH 0/2] Two more pasemi_mac patches for 2.6.26 Olof Johansson
2008-03-26  1:57 ` [PATCH 1/2] pasemi_mac: Jumbo frame bugfixes Olof Johansson
2008-03-26  1:58 ` [PATCH 2/2] pasemi_mac: Netpoll support Olof Johansson
2008-03-26 12:41   ` Valentine Barshak [this message]
2008-03-26 15:08     ` Olof Johansson
2008-03-27 22:40   ` [PATCH 2/2 v2] " Olof Johansson
2008-03-29  2:11     ` Jeff Garzik
2008-03-26  4:12 ` [PATCH 0/2] Two more pasemi_mac patches for 2.6.26 Jeff Garzik
2008-03-27 19:22   ` Olof Johansson
2008-03-27 19:41     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47EA445D.9090509@ru.mvista.com \
    --to=vbarshak@ru.mvista.com \
    --cc=jgarzik@pobox.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=pasemi-linux@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).