From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Yasevich Subject: Re: SCTP control socket question Date: Thu, 27 Mar 2008 10:01:11 -0400 Message-ID: <47EBA8A7.4080503@hp.com> References: <1206619433.32459.9.camel@iris.sw.ru> <47EB9794.7010407@hp.com> <1206623398.32459.19.camel@iris.sw.ru> <47EB9E0B.2030400@hp.com> <1206625405.2109.7.camel@iris.sw.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Netdev List , lksctp-developers@lists.sourceforge.net To: "Denis V. Lunev" Return-path: Received: from g4t0017.houston.hp.com ([15.201.24.20]:45448 "EHLO g4t0017.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755648AbYC0OBN (ORCPT ); Thu, 27 Mar 2008 10:01:13 -0400 In-Reply-To: <1206625405.2109.7.camel@iris.sw.ru> Sender: netdev-owner@vger.kernel.org List-ID: Denis V. Lunev wrote: > On Thu, 2008-03-27 at 09:15 -0400, Vlad Yasevich wrote: >> Denis V. Lunev wrote: >>> On Thu, 2008-03-27 at 08:48 -0400, Vlad Yasevich wrote: >>>> Denis V. Lunev wrote: >>>>> Hello, Vlad! >>>>> >>>>> I have read SCTP sources and found that SCTP control socket >>>>> (sctp_ctl_socket) remains hashed unlike similar staff in UDP/TCP etc. >>>>> >>>>> Am I wrong, that it should not be hashed or not? >>>> Why do you believe that the socket is hashed? That socket is only >>>> allocated and referenced. It's should not be in any hash tables >>>> since we hold a global reference on it. >>> sctp_ctl_sock_init >>> __sock_create >>> inet(6)_create >>> sk->sk_prot->hash(sk); >>> >>> For this purpose sk->sk_prot->unhash is explicitly called for ICMP/TCP >>> etc cases. >>> >>> Regards, >>> Den >>> >> Ahhh... ;-) >> >> struct proto sctp_prot = { >> ... >> .hash = sctp_hash, >> ... >> } >> >> static void sctp_hash(struct sock *sk) >> { >> /* STUB */ >> } >> >> >> SCTP currently does't do any hashing on the sockets. It hashes SCTP structures >> that live under the socket. > > will you mind against this? > That's fine. My one concern is that someone may erroneously interpret that SCTP sockets are derived from inet_connection_sock, but I can live with that. -vlad