From: Jeff Garzik <jeff@garzik.org>
To: Grant Grundler <grundler@parisc-linux.org>
Cc: netdev@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] 2.6.25-rc4 de_stop_rxtx polling wrong
Date: Fri, 28 Mar 2008 18:02:47 -0400 [thread overview]
Message-ID: <47ED6B07.5000101@garzik.org> (raw)
In-Reply-To: <20080324050933.GA9944@colo.lackof.org>
Grant Grundler wrote:
> On Mon, Mar 17, 2008 at 08:13:19AM -0400, Jeff Garzik wrote:
>> Grant Grundler wrote:
>>> Jeff,
>>> This untested patch _should_ fix:
>>> "(net de2104x) Kernel panic with de2104x tulip driver on boot"
>>> http://bugzilla.kernel.org/show_bug.cgi?id=3156
>>> But the bug submitter isn't responding. Same fix has been applied
>>> to tulip.c (several years ago) and uli526x.c (Feb 2008) drivers.
>>> Patch was originally against 2.6.23 but applies clean against 2.6.25-rc4.
>>> [ The panic reported in the bug report was removed in a recently
>>> (march 2008) accepted patch from Ondrej Zary. ]
>>> Signed-off-by: Grant Grundler <grundler@parisc-linux.org>
>> applied
>
> Thanks!
>
>> Please include comments like "Jeff," and "Patch was originally[...]" after
>> the "---" separator, so that the automated tools may omit these comments
>> without human intervention.
>
> Which separator is that? I didn't explicitly add one unless you are
> referring to the patch itself.
See #14 of Documentation/SubmittingPatches.
Basically, anything after "---" in the email body (except for the patch
content itself) is intentionally ignored -- and thus is used for
comments like "Jeff, quit sitting on your ass and apply this damned
patch" that are relevant but do not belong in the permanent kernel history.
> Or tell me which automated tool you are using and I'd be happy to
> figure out how to seperate logistical comments from what should
> go in the "change log" (ie land in git history).
git-am, Linus's tool that many of us git'ers use for importing patches
from email.
Jeff
next prev parent reply other threads:[~2008-03-28 22:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-09 1:33 [PATCH] 2.6.25-rc4 de_stop_rxtx polling wrong Grant Grundler
2008-03-17 12:13 ` Jeff Garzik
2008-03-24 5:09 ` Grant Grundler
2008-03-28 22:02 ` Jeff Garzik [this message]
2008-03-29 2:47 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47ED6B07.5000101@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=grundler@parisc-linux.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).