From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] 2.6.25-rc4 de_stop_rxtx polling wrong Date: Fri, 28 Mar 2008 18:02:47 -0400 Message-ID: <47ED6B07.5000101@garzik.org> References: <20080309013316.GD25083@colo.lackof.org> <47DE605F.1060100@garzik.org> <20080324050933.GA9944@colo.lackof.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, akpm@linux-foundation.org To: Grant Grundler Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:53472 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758415AbYC1WCt (ORCPT ); Fri, 28 Mar 2008 18:02:49 -0400 In-Reply-To: <20080324050933.GA9944@colo.lackof.org> Sender: netdev-owner@vger.kernel.org List-ID: Grant Grundler wrote: > On Mon, Mar 17, 2008 at 08:13:19AM -0400, Jeff Garzik wrote: >> Grant Grundler wrote: >>> Jeff, >>> This untested patch _should_ fix: >>> "(net de2104x) Kernel panic with de2104x tulip driver on boot" >>> http://bugzilla.kernel.org/show_bug.cgi?id=3156 >>> But the bug submitter isn't responding. Same fix has been applied >>> to tulip.c (several years ago) and uli526x.c (Feb 2008) drivers. >>> Patch was originally against 2.6.23 but applies clean against 2.6.25-rc4. >>> [ The panic reported in the bug report was removed in a recently >>> (march 2008) accepted patch from Ondrej Zary. ] >>> Signed-off-by: Grant Grundler >> applied > > Thanks! > >> Please include comments like "Jeff," and "Patch was originally[...]" after >> the "---" separator, so that the automated tools may omit these comments >> without human intervention. > > Which separator is that? I didn't explicitly add one unless you are > referring to the patch itself. See #14 of Documentation/SubmittingPatches. Basically, anything after "---" in the email body (except for the patch content itself) is intentionally ignored -- and thus is used for comments like "Jeff, quit sitting on your ass and apply this damned patch" that are relevant but do not belong in the permanent kernel history. > Or tell me which automated tool you are using and I'd be happy to > figure out how to seperate logistical comments from what should > go in the "change log" (ie land in git history). git-am, Linus's tool that many of us git'ers use for importing patches from email. Jeff