From: Hideo AOKI <haoki@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: herbert@gondor.apana.org.au, netdev@vger.kernel.org, haoki@redhat.com
Subject: Re: [RFC] [NET] [0/2] pskb_expand_head() bugfix
Date: Fri, 28 Mar 2008 21:14:23 -0400 [thread overview]
Message-ID: <47ED97EF.9070601@redhat.com> (raw)
In-Reply-To: <20080327.164935.45964955.davem@davemloft.net>
Hello,
David Miller wrote:
> From: Hideo AOKI <haoki@redhat.com>
> Date: Wed, 26 Mar 2008 16:47:35 -0400
>
>> I think that it is inconvenient for caller functions to need
>> updateing truesize by themselves.
>
> Most cases what I can see are in spots where skb->truesize
> cannot be modified because the SKB is possibly charged
> to a socket.
>
> In these limited situations where skb->truesize adjustments
> really are needed, and legal, it is no harm to open code
> things.
Thank you for the comments.
I understood that updating truesize by caller wasn't problem.
And, I may misunderstand the spots where truesize can't be changed.
Then, I make patch to update truesize for each network subsystem and
ask a review of the patch.
Best regards,
Hideo
--
Hitachi Computer Products (America) Inc.
next prev parent reply other threads:[~2008-03-29 1:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-25 18:39 [RFC] [NET] [0/2] pskb_expand_head() bugfix Hideo AOKI
2008-03-25 18:41 ` [RFC PATCH] [NET] [1/2] revert audit_expand() Hideo AOKI
2008-03-25 18:41 ` [RFC PATCH] [NET] [2/2] pskb_expand_head() updates truesize Hideo AOKI
2008-03-25 23:55 ` [RFC] [NET] [0/2] pskb_expand_head() bugfix Herbert Xu
2008-03-26 20:47 ` Hideo AOKI
2008-03-27 0:13 ` Herbert Xu
2008-03-29 1:01 ` Hideo AOKI
2008-03-27 23:49 ` David Miller
2008-03-29 1:14 ` Hideo AOKI [this message]
2008-03-27 23:48 ` David Miller
2008-03-29 1:02 ` Hideo AOKI
2008-03-29 1:11 ` David Miller
2008-03-29 1:21 ` Hideo AOKI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47ED97EF.9070601@redhat.com \
--to=haoki@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).