From: Jeff Garzik <jeff@garzik.org>
To: Auke Kok <auke-jan.h.kok@intel.com>
Cc: netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net
Subject: Re: [PATCH 4/8] e1000e: limit EEPROM size accesses
Date: Fri, 28 Mar 2008 21:58:53 -0400 [thread overview]
Message-ID: <47EDA25D.7040406@garzik.org> (raw)
In-Reply-To: <20080328161521.6562.23976.stgit@localhost.localdomain>
Auke Kok wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
> ---
>
> drivers/net/e1000e/82571.c | 4 ++++
> drivers/net/e1000e/es2lan.c | 4 ++++
> 2 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/e1000e/82571.c b/drivers/net/e1000e/82571.c
> index f7e1619..9b46a00 100644
> --- a/drivers/net/e1000e/82571.c
> +++ b/drivers/net/e1000e/82571.c
> @@ -171,6 +171,10 @@ static s32 e1000_init_nvm_params_82571(struct e1000_hw *hw)
> * for setting word_size.
> */
> size += NVM_WORD_SIZE_BASE_SHIFT;
> +
> + /* EEPROM access above 16k is unsupported */
> + if (size > 14)
> + size = 14;
> nvm->word_size = 1 << size;
> break;
> }
> diff --git a/drivers/net/e1000e/es2lan.c b/drivers/net/e1000e/es2lan.c
> index e3f4aee..2689e4b 100644
> --- a/drivers/net/e1000e/es2lan.c
> +++ b/drivers/net/e1000e/es2lan.c
> @@ -178,6 +178,10 @@ static s32 e1000_init_nvm_params_80003es2lan(struct e1000_hw *hw)
> * for setting word_size.
> */
> size += NVM_WORD_SIZE_BASE_SHIFT;
> +
> + /* EEPROM access above 16k is unsupported */
> + if (size > 14)
> + size = 14;
> nvm->word_size = 1 << size;
Is this 2.6.25-rc material?
next prev parent reply other threads:[~2008-03-29 1:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 16:15 [PATCH 1/8] e1000e: reformat comment blocks, cosmetic changes only Auke Kok
2008-03-28 16:15 ` [PATCH 2/8] e1000e: rename mc_addr_list_update Auke Kok
2008-03-28 16:15 ` [PATCH 3/8] e1000e: reorganize PHY and flow control interface Auke Kok
2008-03-28 16:15 ` [PATCH 4/8] e1000e: limit EEPROM size accesses Auke Kok
2008-03-29 1:58 ` Jeff Garzik [this message]
2008-03-31 16:33 ` Kok, Auke
2008-03-28 16:15 ` [PATCH 5/8] e1000e: Make arrays out of these Rx/Tx registers Auke Kok
2008-03-28 16:15 ` [PATCH 6/8] e1000e: convert ndev_ printks to something smaller Auke Kok
2008-03-29 2:03 ` Jeff Garzik
2008-03-31 18:36 ` Kok, Auke
2008-03-31 19:09 ` Joe Perches
2008-04-02 18:55 ` [E1000-devel] " Kok, Auke
2008-03-28 16:15 ` [PATCH 7/8] e1000e: rename a few functions Auke Kok
2008-03-28 16:15 ` [PATCH 8/8] e1000e: reformat register test code, fix some minor initialization Auke Kok
2008-03-29 2:16 ` [PATCH 1/8] e1000e: reformat comment blocks, cosmetic changes only Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47EDA25D.7040406@garzik.org \
--to=jeff@garzik.org \
--cc=auke-jan.h.kok@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).