From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 6/8] e1000e: convert ndev_ printks to something smaller Date: Fri, 28 Mar 2008 22:03:59 -0400 Message-ID: <47EDA38F.6080301@garzik.org> References: <20080328161503.6562.44329.stgit@localhost.localdomain> <20080328161531.6562.8515.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org To: Auke Kok Return-path: In-Reply-To: <20080328161531.6562.8515.stgit@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: e1000-devel-bounces@lists.sourceforge.net Errors-To: e1000-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org Auke Kok wrote: > From: Bruce Allan > > The ndev_* printk's are too lenghty and we don't need to specify > the adapter/netdev struct at all, making this a lot more readable. > > Signed-off-by: Bruce Allan > Signed-off-by: Auke Kok > --- > > drivers/net/e1000e/e1000.h | 27 ++++---- > drivers/net/e1000e/ethtool.c | 38 +++++------ > drivers/net/e1000e/netdev.c | 148 +++++++++++++++++++----------------------- > drivers/net/e1000e/param.c | 31 +++------ > 4 files changed, 108 insertions(+), 136 deletions(-) This stuff should just be removed. Either the code should be outputting "ethX: blahblah" via printk(), or the code should be outputting the standard dev_printk() prefix [driver name, PCI device info]. Also, it is recommended to use the NETIF_MSG_xxx bits to permit fine-grained control over which messages are output, on a per-port basis (controlled via ethtool). grep around for 'msg_enable' Jeff ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace