From: Jeff Garzik <jgarzik@pobox.com>
To: Sebastian Siewior <bigeasy@linutronix.de>
Cc: uclinux-dev@uclinux.org, netdev@vger.kernel.org,
Greg Ungerer <gerg@uclinux.org>
Subject: Re: [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu driver
Date: Fri, 28 Mar 2008 22:21:05 -0400 [thread overview]
Message-ID: <47EDA791.4090402@pobox.com> (raw)
In-Reply-To: <20080327140041.072611004@linutronix.de>
Sebastian Siewior wrote:
> I got into this after turning on spinlock debugging.
>
> Jeff: The dev->hard_start_xmit callback is always called from softirq
> context so it is save to use spin_lock_irq(), right?
>
> Greg: The isr (fec_enet_rx()) calls three functions. All
> but fec_enet_rx() are grabbing the spinlock. Is this on purpose?
wanted for 2.6.25? ACKs from maintainer?
next prev parent reply other threads:[~2008-03-29 2:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-27 14:00 [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu driver Sebastian Siewior
2008-03-27 14:00 ` [PATCH / RFC 1/2] fec: kill warnings Sebastian Siewior
2008-03-27 14:00 ` [PATCH / RFC 2/2] fec: fixup spinlocks Sebastian Siewior
2008-03-28 6:58 ` Greg Ungerer
2008-03-28 9:24 ` Sebastian Siewior
2008-03-28 10:24 ` Greg Ungerer
2008-03-28 6:51 ` [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu driver Greg Ungerer
2008-04-02 11:28 ` Sebastian Siewior
2008-04-02 12:50 ` Greg Ungerer
2008-03-29 2:19 ` Jeff Garzik
2008-03-29 2:21 ` Jeff Garzik [this message]
2008-04-02 11:11 ` Sebastian Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47EDA791.4090402@pobox.com \
--to=jgarzik@pobox.com \
--cc=bigeasy@linutronix.de \
--cc=gerg@uclinux.org \
--cc=netdev@vger.kernel.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).