From: Wang Chen <wangchen@cn.fujitsu.com>
To: "David S. Miller" <davem@davemloft.net>,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Cc: NETDEV <netdev@vger.kernel.org>
Subject: [2.6 PATCH] IPV6: Check length of optval provided by user in setsockopt()
Date: Mon, 31 Mar 2008 17:08:38 +0800 [thread overview]
Message-ID: <47F0AA16.1070900@cn.fujitsu.com> (raw)
Check length of setsockopt's optval, which provided by user, before copy it
from user space.
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
---
net/ipv6/ipv6_sockglue.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c
index bf2a686..1ad0ac9 100644
--- a/net/ipv6/ipv6_sockglue.c
+++ b/net/ipv6/ipv6_sockglue.c
@@ -557,6 +557,9 @@ done:
{
struct ipv6_mreq mreq;
+ if (optlen != sizeof(struct ipv6_mreq))
+ goto e_inval;
+
retv = -EPROTO;
if (inet_sk(sk)->is_icsk)
break;
@@ -595,6 +598,9 @@ done:
struct group_req greq;
struct sockaddr_in6 *psin6;
+ if (optlen != sizeof(struct group_req))
+ goto e_inval;
+
retv = -EFAULT;
if (copy_from_user(&greq, optval, sizeof(struct group_req)))
break;
--
1.5.3.4
next reply other threads:[~2008-03-31 9:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-31 9:08 Wang Chen [this message]
2008-03-31 9:15 ` [2.6 PATCH] IPV6: Check length of optval provided by user in setsockopt() YOSHIFUJI Hideaki / 吉藤英明
2008-03-31 10:46 ` Wang Chen
2008-03-31 10:53 ` YOSHIFUJI Hideaki / 吉藤英明
2008-03-31 11:04 ` Wang Chen
2008-04-07 1:42 ` Wang Chen
2008-04-11 7:15 ` YOSHIFUJI Hideaki / 吉藤英明
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F0AA16.1070900@cn.fujitsu.com \
--to=wangchen@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).