[BUILD_FAILURE] linux-next: Tree for March 31 build fails with CONFIG_SLICOSS=y

[BUILD_FAILURE] linux-next: Tree for March 31 build fails with CONFIG_SLICOSS=y

[Kamalesh Babulal]

Hi Stephen,

The kernel next-20080331 kernel build fails with Alacritech's IS-NIC gigabit ethernet
driver on powerpc with allyesconfig (with # CONFIG_NOVFS is not set)

  CC      drivers/net/slicoss/slicoss.o
drivers/net/slicoss/slicoss.c: In function ‘slic_xmit_build_request’:
drivers/net/slicoss/slicoss.c:933: error: ‘Stop’ undeclared (first use in this function)
drivers/net/slicoss/slicoss.c:933: error: (Each undeclared identifier is reported only once
drivers/net/slicoss/slicoss.c:933: error: for each function it appears in.)
drivers/net/slicoss/slicoss.c:933: error: expected ‘;’ before ‘Compilation’
drivers/net/slicoss/slicoss.c: In function ‘slic_link_event_handler’:
drivers/net/slicoss/slicoss.c:1420: error: ‘Stop’ undeclared (first use in this function)
drivers/net/slicoss/slicoss.c:1420: error: expected ‘;’ before ‘compilation’
drivers/net/slicoss/slicoss.c: In function ‘slic_if_init’:
drivers/net/slicoss/slicoss.c:1848: error: ‘Stop’ undeclared (first use in this function)
drivers/net/slicoss/slicoss.c:1848: error: expected ‘;’ before ‘Compilations’
drivers/net/slicoss/slicoss.c: In function ‘slic_card_init’:
drivers/net/slicoss/slicoss.c:2518: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c: In function ‘slic_timer_get_stats’:
drivers/net/slicoss/slicoss.c:3269: error: ‘Stop’ undeclared (first use in this function)
drivers/net/slicoss/slicoss.c:3269: error: expected ‘;’ before ‘compilation’
drivers/net/slicoss/slicoss.c: In function ‘slic_link_upr_complete’:
drivers/net/slicoss/slicoss.c:3683: error: ‘Stop’ undeclared (first use in this function)
drivers/net/slicoss/slicoss.c:3683: error: expected ‘;’ before ‘Compilation’
drivers/net/slicoss/slicoss.c: In function ‘slic_eeprom_cksum’:
drivers/net/slicoss/slicoss.c:3806: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c: In function ‘slic_rspqueue_init’:
drivers/net/slicoss/slicoss.c:3901: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:3901: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c: In function ‘slic_rspqueue_getnext’:
drivers/net/slicoss/slicoss.c:3990: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:3990: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4004: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4004: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4009: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4009: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c: In function ‘slic_cmdqmem_addpage’:
drivers/net/slicoss/slicoss.c:4056: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4056: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c: In function ‘slic_cmdq_init’:
drivers/net/slicoss/slicoss.c:4081: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4081: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c: In function ‘slic_cmdq_addcmdpage’:
drivers/net/slicoss/slicoss.c:4184: error: implicit declaration of function ‘virt_to_bus’
drivers/net/slicoss/slicoss.c:4224: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4224: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4230: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4230: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c: In function ‘slic_cmdq_getdone’:
drivers/net/slicoss/slicoss.c:4271: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4271: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c: In function ‘slic_cmdq_putdone’:
drivers/net/slicoss/slicoss.c:4287: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4287: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4289: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4289: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c: In function ‘slic_cmdq_putdone_irq’:
drivers/net/slicoss/slicoss.c:4301: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4301: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4303: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c:4303: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c: In function ‘slic_rcvqueue_fill’:
drivers/net/slicoss/slicoss.c:4425: warning: cast from pointer to integer of different size
drivers/net/slicoss/slicoss.c: In function ‘slic_rcvqueue_reinsert’:
drivers/net/slicoss/slicoss.c:4504: warning: cast from pointer to integer of different size
make[3]: *** [drivers/net/slicoss/slicoss.o] Error 1
make[2]: *** [drivers/net/slicoss] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2



-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

Re: [BUILD_FAILURE] linux-next: Tree for March 31 build fails with CONFIG_SLICOSS=y

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 6226 bytes --]

Hi Greg,

On Mon, 31 Mar 2008 18:47:10 +0530 Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
>
> The kernel next-20080331 kernel build fails with Alacritech's IS-NIC gigabit ethernet
> driver on powerpc with allyesconfig (with # CONFIG_NOVFS is not set)
> 
>   CC      drivers/net/slicoss/slicoss.o
> drivers/net/slicoss/slicoss.c: In function ‘slic_xmit_build_request’:
> drivers/net/slicoss/slicoss.c:933: error: ‘Stop’ undeclared (first use in this function)
> drivers/net/slicoss/slicoss.c:933: error: (Each undeclared identifier is reported only once
> drivers/net/slicoss/slicoss.c:933: error: for each function it appears in.)
> drivers/net/slicoss/slicoss.c:933: error: expected ‘;’ before ‘Compilation’
> drivers/net/slicoss/slicoss.c: In function ‘slic_link_event_handler’:
> drivers/net/slicoss/slicoss.c:1420: error: ‘Stop’ undeclared (first use in this function)
> drivers/net/slicoss/slicoss.c:1420: error: expected ‘;’ before ‘compilation’
> drivers/net/slicoss/slicoss.c: In function ‘slic_if_init’:
> drivers/net/slicoss/slicoss.c:1848: error: ‘Stop’ undeclared (first use in this function)
> drivers/net/slicoss/slicoss.c:1848: error: expected ‘;’ before ‘Compilations’
> drivers/net/slicoss/slicoss.c: In function ‘slic_card_init’:
> drivers/net/slicoss/slicoss.c:2518: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c: In function ‘slic_timer_get_stats’:
> drivers/net/slicoss/slicoss.c:3269: error: ‘Stop’ undeclared (first use in this function)
> drivers/net/slicoss/slicoss.c:3269: error: expected ‘;’ before ‘compilation’
> drivers/net/slicoss/slicoss.c: In function ‘slic_link_upr_complete’:
> drivers/net/slicoss/slicoss.c:3683: error: ‘Stop’ undeclared (first use in this function)
> drivers/net/slicoss/slicoss.c:3683: error: expected ‘;’ before ‘Compilation’
> drivers/net/slicoss/slicoss.c: In function ‘slic_eeprom_cksum’:
> drivers/net/slicoss/slicoss.c:3806: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c: In function ‘slic_rspqueue_init’:
> drivers/net/slicoss/slicoss.c:3901: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:3901: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c: In function ‘slic_rspqueue_getnext’:
> drivers/net/slicoss/slicoss.c:3990: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:3990: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4004: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4004: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4009: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4009: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c: In function ‘slic_cmdqmem_addpage’:
> drivers/net/slicoss/slicoss.c:4056: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4056: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c: In function ‘slic_cmdq_init’:
> drivers/net/slicoss/slicoss.c:4081: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4081: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c: In function ‘slic_cmdq_addcmdpage’:
> drivers/net/slicoss/slicoss.c:4184: error: implicit declaration of function ‘virt_to_bus’
> drivers/net/slicoss/slicoss.c:4224: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4224: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4230: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4230: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c: In function ‘slic_cmdq_getdone’:
> drivers/net/slicoss/slicoss.c:4271: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4271: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c: In function ‘slic_cmdq_putdone’:
> drivers/net/slicoss/slicoss.c:4287: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4287: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4289: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4289: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c: In function ‘slic_cmdq_putdone_irq’:
> drivers/net/slicoss/slicoss.c:4301: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4301: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4303: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c:4303: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c: In function ‘slic_rcvqueue_fill’:
> drivers/net/slicoss/slicoss.c:4425: warning: cast from pointer to integer of different size
> drivers/net/slicoss/slicoss.c: In function ‘slic_rcvqueue_reinsert’:
> drivers/net/slicoss/slicoss.c:4504: warning: cast from pointer to integer of different size

Strike two!  Again, these drivers need to build (or not try to build) for
all architectures ... Its out until you tell me the above is true.

#if defined(CONFIG_X86_64)
        hcmd->cmdsize = (ulong32) ((((ulong64) & ihcmd->u.slic_buffers.bufs[1] -
                                     (ulong64) hcmd) + 31) >> 5);
#elif defined(CONFIG_X86)
        hcmd->cmdsize = ((((ulong32) & ihcmd->u.slic_buffers.bufs[1] -
                           (ulong32) hcmd) + 31) >> 5);
#else
        Stop Compilation;
#endif

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [BUILD_FAILURE] linux-next: Tree for March 31 build fails with CONFIG_SLICOSS=y

[Greg KH]

On Tue, Apr 01, 2008 at 12:31:10AM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> Strike two!  Again, these drivers need to build (or not try to build) for
> all architectures ... Its out until you tell me the above is true.
> 
> #if defined(CONFIG_X86_64)
>         hcmd->cmdsize = (ulong32) ((((ulong64) & ihcmd->u.slic_buffers.bufs[1] -
>                                      (ulong64) hcmd) + 31) >> 5);
> #elif defined(CONFIG_X86)
>         hcmd->cmdsize = ((((ulong32) & ihcmd->u.slic_buffers.bufs[1] -
>                            (ulong32) hcmd) + 31) >> 5);
> #else
>         Stop Compilation;

Ah, missed that one, that's why it built on my machines (x86-64 and
i386), but would die on anything else.  That test is just wrong, I'll
fix it up to get it to build on all arches (doesn't mean it will run
though, it assumes that port io is memory mapped flat on all machines
and still needs a lot of work to be fixed.

thanks,

greg k-h