From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH net-2.6.26] netlink: make socket filters work on netlink Date: Mon, 31 Mar 2008 22:15:59 +0200 Message-ID: <47F1467F.2080407@trash.net> References: <47EAAFEC.6000805@trash.net> <20080331123311.64e4ca37@extreme> <47F13E43.2040404@trash.net> <20080331.130757.199769025.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: shemminger@vyatta.com, hadi@cyberus.ca, netdev@vger.kernel.org To: David Miller Return-path: Received: from stinky.trash.net ([213.144.137.162]:35246 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752380AbYCaUQC (ORCPT ); Mon, 31 Mar 2008 16:16:02 -0400 In-Reply-To: <20080331.130757.199769025.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: David Miller wrote: > From: Patrick McHardy > Date: Mon, 31 Mar 2008 21:40:51 +0200 > >> Thanks. It seems it parses only top-level attributes, which >> is probably why you didn't need the nlattr_find command I >> used in my patch. The problem with this is that finding and >> parsing nested attributes using the existing BPF commands is >> complicated since you need to fully parse netlink headers >> and walk through them. You can't even reuse that part for >> multiple nested attributes since you can't jump backwards. >> So I think it would be preferrable to have a simpler method >> for this. > > Agreed. I'll cook something up based on my and Stephen's patches.