* [PATCH] cxgb3: Fix __must_check warning with dev_dbg.
@ 2008-04-02 11:50 Dan Noe
2008-04-02 15:49 ` Chris Snook
0 siblings, 1 reply; 4+ messages in thread
From: Dan Noe @ 2008-04-02 11:50 UTC (permalink / raw)
To: netdev; +Cc: Dan Noe
Fix the warning:
drivers/net/cxgb3/cxgb3_main.c: In function ‘offload_open’:
drivers/net/cxgb3/cxgb3_main.c:936: warning: ignoring return value of
‘sysfs_create_group’, declared with attribute warn_unused_result
Now the return value is checked; if sysfs_create_group() returns failure,
a warning is printed using dev_dbg, and the code continues as before. Use
of dev_dbg ensures printk is not needlessly included unless desired for
debugging.
Signed-off-by: Dan Noe <dpn@isomerica.net>
---
drivers/net/cxgb3/cxgb3_main.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c
index fd2e05b..0ddc34a 100644
--- a/drivers/net/cxgb3/cxgb3_main.c
+++ b/drivers/net/cxgb3/cxgb3_main.c
@@ -1014,8 +1014,8 @@ static int offload_open(struct net_device *dev)
adapter->port[0]->mtu : 0xffff);
init_smt(adapter);
- /* Never mind if the next step fails */
- sysfs_create_group(&tdev->lldev->dev.kobj, &offload_attr_group);
+ if (sysfs_create_group(&tdev->lldev->dev.kobj, &offload_attr_group))
+ dev_dbg(&dev->dev, ": cannot create sysfs group\n");
/* Call back all registered clients */
cxgb3_add_clients(tdev);
--
1.5.2.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] cxgb3: Fix __must_check warning with dev_dbg.
2008-04-02 11:50 [PATCH] cxgb3: Fix __must_check warning with dev_dbg Dan Noe
@ 2008-04-02 15:49 ` Chris Snook
0 siblings, 0 replies; 4+ messages in thread
From: Chris Snook @ 2008-04-02 15:49 UTC (permalink / raw)
To: Dan Noe; +Cc: netdev
Dan Noe wrote:
> Fix the warning:
> drivers/net/cxgb3/cxgb3_main.c: In function ‘offload_open’:
> drivers/net/cxgb3/cxgb3_main.c:936: warning: ignoring return value of
> ‘sysfs_create_group’, declared with attribute warn_unused_result
>
> Now the return value is checked; if sysfs_create_group() returns failure,
> a warning is printed using dev_dbg, and the code continues as before. Use
> of dev_dbg ensures printk is not needlessly included unless desired for
> debugging.
>
> Signed-off-by: Dan Noe <dpn@isomerica.net>
> ---
> drivers/net/cxgb3/cxgb3_main.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c
> index fd2e05b..0ddc34a 100644
> --- a/drivers/net/cxgb3/cxgb3_main.c
> +++ b/drivers/net/cxgb3/cxgb3_main.c
> @@ -1014,8 +1014,8 @@ static int offload_open(struct net_device *dev)
> adapter->port[0]->mtu : 0xffff);
> init_smt(adapter);
>
> - /* Never mind if the next step fails */
> - sysfs_create_group(&tdev->lldev->dev.kobj, &offload_attr_group);
> + if (sysfs_create_group(&tdev->lldev->dev.kobj, &offload_attr_group))
> + dev_dbg(&dev->dev, ": cannot create sysfs group\n");
>
> /* Call back all registered clients */
> cxgb3_add_clients(tdev);
Close. dev_dbg() invokes dev_printk(), which provides the ": ", so you
can take those two characters out of the string literal.
-- Chris
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] cxgb3: Fix __must_check warning with dev_dbg.
@ 2008-04-13 2:34 Dan Noe
2008-04-17 0:54 ` Jeff Garzik
0 siblings, 1 reply; 4+ messages in thread
From: Dan Noe @ 2008-04-13 2:34 UTC (permalink / raw)
To: jgarzik; +Cc: netdev, Dan Noe
Fix the warning:
drivers/net/cxgb3/cxgb3_main.c: In function ‘offload_open’:
drivers/net/cxgb3/cxgb3_main.c:936: warning: ignoring return value of
‘sysfs_create_group’, declared with attribute warn_unused_result
Now the return value is checked; if sysfs_create_group() returns failure,
a warning is printed using dev_dbg, and the code continues as before. Use
of dev_dbg ensures printk is not needlessly included unless desired for
debugging.
Signed-off-by: Dan Noe <dpn@isomerica.net>
---
drivers/net/cxgb3/cxgb3_main.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c
index fd2e05b..05e5f59 100644
--- a/drivers/net/cxgb3/cxgb3_main.c
+++ b/drivers/net/cxgb3/cxgb3_main.c
@@ -1014,8 +1014,8 @@ static int offload_open(struct net_device *dev)
adapter->port[0]->mtu : 0xffff);
init_smt(adapter);
- /* Never mind if the next step fails */
- sysfs_create_group(&tdev->lldev->dev.kobj, &offload_attr_group);
+ if (sysfs_create_group(&tdev->lldev->dev.kobj, &offload_attr_group))
+ dev_dbg(&dev->dev, "cannot create sysfs group\n");
/* Call back all registered clients */
cxgb3_add_clients(tdev);
--
1.5.2.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] cxgb3: Fix __must_check warning with dev_dbg.
2008-04-13 2:34 Dan Noe
@ 2008-04-17 0:54 ` Jeff Garzik
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2008-04-17 0:54 UTC (permalink / raw)
To: Dan Noe; +Cc: netdev
Dan Noe wrote:
> Fix the warning:
> drivers/net/cxgb3/cxgb3_main.c: In function ‘offload_open’:
> drivers/net/cxgb3/cxgb3_main.c:936: warning: ignoring return value of
> ‘sysfs_create_group’, declared with attribute warn_unused_result
>
> Now the return value is checked; if sysfs_create_group() returns failure,
> a warning is printed using dev_dbg, and the code continues as before. Use
> of dev_dbg ensures printk is not needlessly included unless desired for
> debugging.
>
> Signed-off-by: Dan Noe <dpn@isomerica.net>
> ---
> drivers/net/cxgb3/cxgb3_main.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c
> index fd2e05b..05e5f59 100644
> --- a/drivers/net/cxgb3/cxgb3_main.c
> +++ b/drivers/net/cxgb3/cxgb3_main.c
> @@ -1014,8 +1014,8 @@ static int offload_open(struct net_device *dev)
> adapter->port[0]->mtu : 0xffff);
> init_smt(adapter);
>
> - /* Never mind if the next step fails */
> - sysfs_create_group(&tdev->lldev->dev.kobj, &offload_attr_group);
> + if (sysfs_create_group(&tdev->lldev->dev.kobj, &offload_attr_group))
> + dev_dbg(&dev->dev, "cannot create sysfs group\n");
>
applied
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-04-17 0:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-02 11:50 [PATCH] cxgb3: Fix __must_check warning with dev_dbg Dan Noe
2008-04-02 15:49 ` Chris Snook
-- strict thread matches above, loose matches on Subject: below --
2008-04-13 2:34 Dan Noe
2008-04-17 0:54 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).