From: Greg Ungerer <gerg@snapgear.com>
To: Sebastian Siewior <bigeasy@linutronix.de>
Cc: Jeff Garzik <jgarzik@pobox.com>,
netdev@vger.kernel.org, uclinux-dev@uclinux.org
Subject: Re: [PATCH 5/5] m68knommu: dont allocate unused interrupts
Date: Thu, 03 Apr 2008 19:34:41 +1000 [thread overview]
Message-ID: <47F4A4B1.3000709@snapgear.com> (raw)
In-Reply-To: <20080403074323.GA778@Chamillionaire.breakpoint.cc>
Sebastian Siewior wrote:
> * Greg Ungerer | 2008-04-03 16:47:58 [+1000]:
>>> This is because we register & enable way more interrupt sources than we
>>> actually handle. FEC_ENET_RXF (packet received), FEC_ENET_TXF (packet
>>> trasmitted) and FEC_ENET_MII (mii command done) are handled by the ISR.
>>> In my case FEC_ENET_RXB caused this because it was not handled, registered
>>> and
>>> rarely the only flag in the status reg. Registering an interrupt source
>>> without
>>> enabling it is also pointless.
>>> This patch removes them all except the three that are handled by the isr.
>> After the last discussions on uclinux-dev about this I have
>> a patch virtualy identical to this prepared for inclusion
>> in the 2.6.26 merge window.
>
> So you drop this one. Great. That's why I asked you about a devel tree.
> The latest uclinux patch is linux-2.6.24-uc0.patch.gz which does not
> contain such a fix. The latest dist snapshot patch is from 2008-03-05
> and is about 147 MiB. I took a look at the diffstat
> (9.67 KB/s) - `uClinux-dist-20070130-20080305.diffstat' saved
> and yes, there are some modifications to fec.c but 10KiB/sec take me
> forever. I stared leeching it. The CVS [1] has no linux-2.6 directory.
> Therefore I assumed that is the latest one.
> I've been browsing the mailing list archive and did not find anything
> close to it (I found multicast discussions for instance).
>
> Could please Cc me in future on your m68k patches? I would setup a git
> tree and feed them there. Alternatively I would be pleased if you could
> give me a pointer to your quilt series since I'm obviously not clever
> enough to find it.
I don't keep a quilt series or a git tree currently.
I release periodically in the form of the -uc patch series.
Regards
Greg
> [1] http://cvs.uclinux.org/cgi-bin/cvsweb.cgi/uClinux-dist/
>
>> Regards
>> Greg
>
> Sebastian
>
--
------------------------------------------------------------------------
Greg Ungerer -- Chief Software Dude EMAIL: gerg@snapgear.com
SnapGear -- a Secure Computing Company PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
next prev parent reply other threads:[~2008-04-03 9:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-02 20:58 [PATCH 0/5] fixup locking on m68knommu fec Sebastian Siewior
2008-04-02 20:58 ` [PATCH 3/5] m68knommu: fec typedef a function Sebastian Siewior
2008-04-02 20:58 ` [PATCH 1/5] fec: kill warnings Sebastian Siewior
2008-04-03 6:30 ` Greg Ungerer
2008-04-03 7:44 ` Sebastian Siewior
2008-04-03 9:30 ` Greg Ungerer
2008-04-02 20:58 ` [PATCH 4/5] m68knommu: fec fixup locking Sebastian Siewior
2008-04-02 20:58 ` [PATCH 5/5] m68knommu: dont allocate unused interrupts Sebastian Siewior
2008-04-03 6:47 ` Greg Ungerer
2008-04-03 7:43 ` Sebastian Siewior
2008-04-03 9:34 ` Greg Ungerer [this message]
2008-04-02 20:58 ` [PATCH 2/5] m68knommu: fec: small coding style cleanup Sebastian Siewior
2008-04-03 6:54 ` [PATCH 0/5] fixup locking on m68knommu fec Greg Ungerer
2008-04-03 7:52 ` Sebastian Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F4A4B1.3000709@snapgear.com \
--to=gerg@snapgear.com \
--cc=bigeasy@linutronix.de \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).