From: Patrick McHardy <kaber@trash.net>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Pavel Emelyanov <xemul@openvz.org>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [RFC][PATCH 1/3] Introduce the net_device_ops structure.
Date: Fri, 04 Apr 2008 17:54:55 +0200 [thread overview]
Message-ID: <47F64F4F.2020006@trash.net> (raw)
In-Reply-To: <20080404081458.197f58ba@extreme>
Stephen Hemminger wrote:
> On Fri, 04 Apr 2008 18:10:52 +0400
> Pavel Emelyanov <xemul@openvz.org> wrote:
>
>> And fill it with copied from net_device.
>>
>> Also make newly created devices be assigned to the
>> (currently empty) nd_default_ops.
>>
>> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
>
> Thanks, I started this a while back but never got to the bottom.
> Please use const where possible (on dev->nd_ops) and in devices.
It might make sense to keep hard_start_xmit and hard_header
in struct net_device since VLAN and Bonding overload them.
next prev parent reply other threads:[~2008-04-04 15:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-04 14:09 [RFC][PATCH 0/3] Make loopback device weight twice as little Pavel Emelyanov
2008-04-04 14:10 ` [RFC][PATCH 1/3] Introduce the net_device_ops structure Pavel Emelyanov
2008-04-04 15:14 ` Stephen Hemminger
2008-04-04 15:54 ` Patrick McHardy [this message]
2008-04-14 4:20 ` David Miller
2008-04-04 14:12 ` [RFC][PATCH 2/3] Move net_device->init callback on net_device_ops Pavel Emelyanov
2008-04-04 14:14 ` [RFC][PATCH 3/3] Move net_device->uninit " Pavel Emelyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F64F4F.2020006@trash.net \
--to=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).