From: Jeff Garzik <jeff@garzik.org>
To: Meelis Roos <mroos@linux.ee>
Cc: netdev@vger.kernel.org, Grant Grundler <grundler@parisc-linux.org>
Subject: Re: [patch] NET: remove support for Davicom 9102 from the Tulip driver
Date: Fri, 04 Apr 2008 17:59:56 -0400 [thread overview]
Message-ID: <47F6A4DC.3070504@garzik.org> (raw)
In-Reply-To: <Pine.SOC.4.64.0804041154150.11646@math.ut.ee>
Meelis Roos wrote:
>>> - { 0x1282, 0x9102, PCI_ANY_ID, PCI_ANY_ID, 0, 0, DM910X },
>
>> applied
>
> Hmm, did you see my yesterdays answer to that patch - that dmfe should
> first be fixed to work on all cards with this PCI ID? Currenty dmfe
> fails to work on at least Sun Fire V100 and Sun Netra X1 boxes, only
> tulip works.
>
Maybe this tulip_core.c code needs to be applied to dmfe.c?
if (tulip_uli_dm_quirk(pdev)) {
csr0 &= ~0x01f100ff;
#if defined(CONFIG_SPARC)
csr0 = (csr0 & ~0xff00) | 0xe000;
#endif
}
A zeroed MAC address leads me to believe that dmfe's SROM parsing isn't
quite as capable as tulip's, though that's just a guess.
Just checked dmfe with sparse and it reports clean, though looking at
the code it could use some cleanups.
Jeff
next prev parent reply other threads:[~2008-04-04 22:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-04 8:56 [patch] NET: remove support for Davicom 9102 from the Tulip driver Meelis Roos
2008-04-04 19:43 ` David Miller
2008-04-04 21:27 ` Jeff Garzik
2008-04-04 21:59 ` Jeff Garzik [this message]
2008-04-04 22:05 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2008-04-03 9:10 Meelis Roos
2008-04-04 21:38 ` Jeff Garzik
2008-04-04 22:02 ` David Miller
2008-04-04 22:06 ` Jeff Garzik
2008-04-04 22:28 ` David Miller
2008-04-04 23:26 ` Grant Grundler
2008-04-07 14:28 ` Meelis Roos
2008-04-09 15:54 ` Grant Grundler
2008-04-02 22:46 Chuck Ebbert
2008-04-04 5:46 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F6A4DC.3070504@garzik.org \
--to=jeff@garzik.org \
--cc=grundler@parisc-linux.org \
--cc=mroos@linux.ee \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).