From: Anthony Liguori <anthony@codemonkey.ws>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Max Krasnyansky <maxk@qualcomm.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH RFC 2/5] vringfd base/offset
Date: Sat, 05 Apr 2008 12:18:59 -0500 [thread overview]
Message-ID: <47F7B483.8090101@codemonkey.ws> (raw)
In-Reply-To: <200804052204.28518.rusty__10896.9346424148$1207397431$gmane$org@rustcorp.com.au>
Rusty Russell wrote:
> It turns out the lguest (and possibly kvm) want the addresses in the
> ring buffer to only cover a certain part of memory, and be offset.
>
> It makes sense that this be an ioctl.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>
<snip>
> @@ -208,12 +232,15 @@ int vring_get_buffer(struct vring_info *
> out_len = &dummy;
>
> *in_len = *out_len = 0;
> -
> - if (unlikely(get_user(head, &vr->ring.avail->ring[head]) != 0))
> +
> + if (unlikely(get_user(head, &vr->ring.avail->ring[vr->last_avail
> + % vr->ring.num])))
Why not & with vr->mask for the sake of consistency with the rest of the
code.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2008-04-05 17:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-05 12:02 [PATCH RFC 1/5] vringfd syscall Rusty Russell
2008-04-05 12:04 ` [PATCH RFC 2/5] vringfd base/offset Rusty Russell
2008-04-05 12:05 ` [PATCH RFC 3/5] tun: vringfd receive support Rusty Russell
2008-04-05 12:06 ` [PATCH RFC 4/5] tun: vringfd xmit support Rusty Russell
2008-04-05 12:09 ` [PATCH RFC 5/5] lguest support Rusty Russell
2008-04-07 5:13 ` [PATCH RFC 4/5] tun: vringfd xmit support Herbert Xu
2008-04-07 7:24 ` Rusty Russell
2008-04-07 7:35 ` David Miller
2008-04-08 1:51 ` Rusty Russell
2008-04-08 19:49 ` [PATCH RFC 3/5] tun: vringfd receive support Max Krasnyansky
2008-04-09 12:46 ` Dor Laor
2008-04-10 17:02 ` Max Krasnyanskiy
2008-04-10 5:44 ` Rusty Russell
2008-04-10 17:18 ` Max Krasnyanskiy
2008-04-05 12:44 ` [PATCH RFC 2/5] vringfd base/offset Avi Kivity
2008-04-06 2:54 ` Rusty Russell
[not found] ` <200804052205.43824.rusty__2650.41595926068$1207397436$gmane$org@rustcorp.com.au>
2008-04-05 17:26 ` [PATCH RFC 3/5] tun: vringfd receive support Anthony Liguori
2008-04-08 5:14 ` [PATCH RFC 2/5] vringfd base/offset Arnd Bergmann
[not found] ` <200804052204.28518.rusty__10896.9346424148$1207397431$gmane$org@rustcorp.com.au>
2008-04-05 17:18 ` Anthony Liguori [this message]
2008-04-06 3:23 ` Rusty Russell
2008-04-07 17:54 ` [PATCH RFC 1/5] vringfd syscall Jonathan Corbet
2008-04-07 22:34 ` Rusty Russell
2008-04-08 2:35 ` Arnd Bergmann
2008-04-09 19:28 ` Jeremy Fitzhardinge
2008-04-12 17:18 ` Marcelo Tosatti
2008-04-12 17:39 ` Marcelo Tosatti
2008-04-12 18:19 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F7B483.8090101@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qualcomm.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).