From: Jarek Poplawski <jarkao2@gmail.com>
To: Pavel Emelyanov <xemul@openvz.org>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
Stephen Hemminger <shemminger@vyatta.com>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH net-2.6.26 2/2] Do not allocate unneeded memory for dev->priv alignment.
Date: Mon, 07 Apr 2008 19:44:02 +0200 [thread overview]
Message-ID: <47FA5D62.5040806@gmail.com> (raw)
In-Reply-To: <47FA4C50.3080405@openvz.org>
Pavel Emelyanov wrote, On 04/07/2008 06:31 PM:
...
> ---
> net/core/dev.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 7aa0112..80e103a 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -4000,7 +4000,8 @@ struct net_device *alloc_netdev_mq(int sizeof_priv, const char *name,
> alloc_size = (sizeof(*dev) + NETDEV_ALIGN_CONST +
> (sizeof(struct net_device_subqueue) * (queue_count - 1))) &
> ~NETDEV_ALIGN_CONST;
> - alloc_size += sizeof_priv + NETDEV_ALIGN_CONST;
> + if (sizeof_priv)
> + alloc_size += sizeof_priv + NETDEV_ALIGN_CONST;
>
> p = kzalloc(alloc_size, GFP_KERNEL);
> if (!p) {
IMHO this second "+ NETDEV_ALIGN_CONST" is needed here because of "~NETDEV_ALIGN_CONST".
Regards,
Jarek P.
next prev parent reply other threads:[~2008-04-07 17:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-07 16:31 [PATCH net-2.6.26 2/2] Do not allocate unneeded memory for dev->priv alignment Pavel Emelyanov
2008-04-07 17:44 ` Jarek Poplawski [this message]
2008-04-08 8:42 ` Pavel Emelyanov
2008-04-08 9:22 ` Jarek Poplawski
2008-04-16 9:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47FA5D62.5040806@gmail.com \
--to=jarkao2@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).