netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Juliusz Chroboczek <jch@pps.jussieu.fr>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Stochastic Fair Blue queue discipline
Date: Tue, 08 Apr 2008 18:44:34 +0200	[thread overview]
Message-ID: <47FBA0F2.3070605@trash.net> (raw)
In-Reply-To: <87skxxb8br.fsf@pirx.pps.jussieu.fr>

> diff -urN empty/sch_sfb.c sch_sfb/sch_sfb.c
> --- empty/sch_sfb.c	1970-01-01 01:00:00.000000000 +0100
> +++ sch_sfb/sch_sfb.c	2008-04-08 00:29:14.000000000 +0200


I wanted to review this, but the CodingStyle issues are
distracting to me, so I guess I'll wait until you've done
the cleanups suggested by Andi.

If you could make your next patch against a kernel tree
that would be also nice.


      parent reply	other threads:[~2008-04-08 16:44 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-07 22:37 [PATCH] Stochastic Fair Blue queue discipline Juliusz Chroboczek
2008-04-08  0:04 ` Patrick McHardy
2008-04-08  0:56   ` Patrick McHardy
2008-04-08 15:28   ` Juliusz Chroboczek
2008-04-08  8:20 ` Andi Kleen
2008-04-08 12:11   ` Patrick McHardy
2008-04-08 15:39     ` Juliusz Chroboczek
2008-04-08 15:45       ` Patrick McHardy
2008-04-09 15:48         ` Juliusz Chroboczek
2008-04-09 16:00           ` Patrick McHardy
2008-04-08 15:38   ` Juliusz Chroboczek
2008-04-08 16:32     ` Andi Kleen
2008-04-08 17:35       ` Juliusz Chroboczek
2008-04-08 17:53         ` Andi Kleen
2008-04-09 15:45           ` Juliusz Chroboczek
2008-04-09 17:49             ` Andi Kleen
2008-04-10  1:23               ` Patrick McHardy
2008-04-10  1:38                 ` Patrick McHardy
2008-04-10 11:17                   ` Juliusz Chroboczek
2008-04-11 13:07                     ` Patrick McHardy
2008-04-10 14:04                   ` Stephen Hemminger
2008-04-10  7:36                 ` Andi Kleen
2008-04-08 16:44 ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47FBA0F2.3070605@trash.net \
    --to=kaber@trash.net \
    --cc=jch@pps.jussieu.fr \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).