netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Kazunori MIYAZAWA <kazunori@miyazawa.org>
Cc: David Miller <davem@davemloft.net>,
	pupilla@hotmail.com, netdev@vger.kernel.org
Subject: Re: [XFRM]: xfrm_user: fix selector family initialization
Date: Thu, 10 Apr 2008 02:18:04 +0200	[thread overview]
Message-ID: <47FD5CBC.6040905@trash.net> (raw)
In-Reply-To: <47FD5B1C.3060005@miyazawa.org>

Kazunori MIYAZAWA wrote:
> David Miller wrote:
>> From: Patrick McHardy <kaber@trash.net>
>> Date: Wed, 09 Apr 2008 17:38:55 +0200
>>
>>>     [XFRM]: xfrm_user: fix selector family initialization
>>>         Commit df9dcb45 ([IPSEC]: Fix inter address family IPsec 
>>> tunnel handling)
>>>     broke openswan by removing the selector initialization for tunnel 
>>> mode
>>>     in case it is uninitialized.
>>>         This patch restores the initialization, fixing openswan, but 
>>> probably
>>>     breaking inter-family tunnels again (unknown since the patch author
>>>     disappeared). The correct thing for inter-family tunnels is probably
>>>     to simply initialize the selector family explicitly.
>>>         Signed-off-by: Patrick McHardy <kaber@trash.net>
>>
>> I've applied this to net-2.6, thanks Patrick.
>>
>> Once we resolve how to get inter-family working without
>> breaking existing setups, we can put better logic back
>> in here.  But for now the regression is more important.
> 
> Sorry, I missed the thread.
> I have no idea to solve the regression.


Wouldn't explicitly initializing the SA family for
inter-family tunnels work?

  reply	other threads:[~2008-04-10  0:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-03  9:42 2.6.25-rc8 regression with openswan Marco Berizzi
2008-04-03 10:01 ` Marco Berizzi
2008-04-03 11:19 ` Patrick McHardy
2008-04-03 11:50   ` Marco Berizzi
2008-04-03 12:06     ` Patrick McHardy
2008-04-03 12:31       ` Marco Berizzi
2008-04-03 12:35         ` Patrick McHardy
2008-04-03 13:52           ` Patrick McHardy
2008-04-03 14:06             ` Marco Berizzi
2008-04-03 14:36               ` Patrick McHardy
2008-04-08 19:08                 ` Patrick McHardy
2008-04-09 15:38                   ` [XFRM]: xfrm_user: fix selector family initialization Patrick McHardy
2008-04-09 22:09                     ` David Miller
2008-04-10  0:11                       ` Kazunori MIYAZAWA
2008-04-10  0:18                         ` Patrick McHardy [this message]
2008-04-10  0:50                           ` Kazunori MIYAZAWA
2008-04-10  0:55                             ` Patrick McHardy
2008-04-14  7:33                     ` Marco Berizzi
2008-04-14  7:36                       ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47FD5CBC.6040905@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=kazunori@miyazawa.org \
    --cc=netdev@vger.kernel.org \
    --cc=pupilla@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).