netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Philip Craig <philipc@snapgear.com>
To: "Kok, Auke" <auke-jan.h.kok@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>, Jeff Garzik <jeff@garzik.org>,
	Matthew Wilcox <matthew@wil.cx>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	NetDev <netdev@vger.kernel.org>,
	e1000-list <e1000-devel@lists.sourceforge.net>,
	linux-pci maillist <linux-pci@atrey.karlin.mff.cuni.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	"Ronciak, John" <john.ronciak@intel.com>,
	"Allan, Bruce W" <bruce.w.allan@intel.com>,
	Greg KH <greg@kroah.com>,
	Arjan van de Ven <arjan@linux.intel.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [patch] e1000=y && e1000e=m regression fix
Date: Fri, 11 Apr 2008 10:46:00 +1000	[thread overview]
Message-ID: <47FEB4C8.3020303@snapgear.com> (raw)
In-Reply-To: <47FE8566.5040809@intel.com>

Kok, Auke wrote:
> Again - If there is a way to auto-enable e1000e in the right way so that more
> systems migrate better then I'm all for it (even if forcing E1000E=y). But it
> seems that the various patches proposed don't cut it and frankly Kconfig is
> completely inadequate as a hardware enabling script since it knows absolutely
> nothing about the hardware in the first place. And it wasn't meant for that
> either. `make oldconfig` is not the answer ;).

One problem is that the meaning of E1000 has been changed.  It covers less
hardware than it used to.

You could add a new option to control the e1000 driver, and make E1000 set
both this new option and E1000E.  Thus it will always cover at least all
the IDs that the original e1000 driver handled.

config E1000
	tristate "Both Intel(R) PRO/1000 Gigabit Ethernet support"
	depends on PCI

config E1000_ONLY
	tristate "Intel(R) PRO/1000 Gigabit Ethernet support" if E1000=n
	default E1000
	depends on PCI

config E1000E
	tristate "Intel(R) PRO/1000 PCI-Express Gigabit Ethernet support" if E1000=n
	default E1000
	depends on PCI

The E1000E prompt restriction is required to upgrade existing E1000=y,
E1000E=m configs to E1000E=y.

But it will also upgrade E1000=y/m,E1000E=n to E1000E=y/m, which may not
always be right.

This still doesn't solve any problems with loading modules for E1000=m.
Loading the e1000 module will still load support for less than it used to.
(Because make oldconfig is not the answer ;-)

  parent reply	other threads:[~2008-04-11  0:46 UTC|newest]

Thread overview: 91+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-04 21:11 [ANNOUNCE] e1000 to e1000e migration of PCI Express devices Kok, Auke
2008-04-04 21:31 ` Dave Hansen
2008-04-04 21:49   ` [E1000-devel] " Kok, Auke
2008-04-04 21:52   ` Jeff Garzik
2008-04-08  8:36 ` Ingo Molnar
2008-04-08 14:21   ` Jeff Garzik
2008-04-08 15:08     ` Jeff Garzik
2008-04-08 14:56   ` Andi Kleen
2008-04-08 16:18   ` Kok, Auke
2008-04-08 18:15     ` Ingo Molnar
2008-04-08 18:39     ` [regression] e1000e broke e1000 (was: Re: [ANNOUNCE] e1000 to e1000e migration of PCI Express devices) Ingo Molnar
2008-04-08 19:32       ` Matthew Wilcox
2008-04-08 19:51         ` Ingo Molnar
2008-04-08 19:56           ` [regression] e1000e broke e1000 Jeff Garzik
2008-04-08 20:06             ` Ingo Molnar
2008-04-08 20:19               ` Jeff Garzik
2008-04-08 20:33                 ` Ingo Molnar
2008-04-08 20:47                   ` [E1000-devel] " Kok, Auke
2008-04-08 20:56                   ` Jeff Garzik
2008-04-09 19:38                     ` [patch] e1000=y && e1000e=m regression fix (was: Re: [regression] e1000e broke e1000) Ingo Molnar
2008-04-09 19:50                       ` [patch] e1000=y && e1000e=m regression fix Jeff Garzik
2008-04-09 20:04                         ` Ingo Molnar
2008-04-09 20:12                       ` Kok, Auke
2008-04-09 20:53                         ` Ingo Molnar
2008-04-10 18:29                         ` Kok, Auke
2008-04-10 19:27                           ` Ingo Molnar
2008-04-10 21:23                             ` Kok, Auke
2008-04-10 21:44                               ` Randy Dunlap
2008-04-10 21:52                                 ` Kok, Auke
2008-04-11  7:54                                 ` Andi Kleen
2008-04-11  0:46                               ` Philip Craig [this message]
2008-04-11 11:26                               ` Ingo Molnar
2008-04-11 11:36                                 ` Christoph Hellwig
2008-04-11 12:16                                   ` Ingo Molnar
2008-04-11 16:22                                     ` Kok, Auke
2008-04-11 16:45                                       ` Christoph Hellwig
2008-04-11 17:26                                         ` Kok, Auke
2008-04-11 17:34                                         ` Linus Torvalds
2008-04-11 17:53                                           ` Matthew Wilcox
2008-04-11 18:51                                             ` Linus Torvalds
2008-04-11 19:01                                               ` Matthew Wilcox
2008-04-11 19:25                                                 ` Willy Tarreau
2008-04-11 19:38                                                   ` Matthew Wilcox
2008-04-11 20:21                                                 ` Linus Torvalds
2008-04-11 20:22                                               ` Krzysztof Halasa
2008-04-11 20:29                                                 ` Linus Torvalds
2008-04-11 21:01                                               ` Dan Noe
2008-04-11 22:06                                           ` Daniel Barkalow
2008-04-11 22:21                                             ` Jeff Garzik
2008-04-11 23:05                                               ` Daniel Barkalow
2008-04-11 23:00                                             ` Linus Torvalds
2008-04-11 23:15                                               ` Daniel Barkalow
2008-04-11 23:43                                               ` Jeff Garzik
2008-04-11 23:58                                                 ` david
2008-04-12 13:07                                                 ` Christoph Hellwig
2008-04-13 21:13                                                 ` Linus Torvalds
2008-04-13 21:34                                                   ` Ondrej Zary
2008-06-09 19:24                                                   ` Ingo Molnar
2008-04-11 17:10                                       ` Martin Mares
2008-04-09 20:49                       ` [patch] e1000=y && e1000e=m regression fix (was: Re: [regression] e1000e broke e1000) Frans Pop
2008-04-09 23:59                         ` Krzysztof Halasa
2008-04-10  1:40                           ` Linus Torvalds
2008-04-10  9:57                             ` Krzysztof Halasa
2008-04-10 14:30                               ` Linus Torvalds
2008-04-10 17:55                                 ` Grant Grundler
2008-04-10 18:04                                   ` Matthew Wilcox
2008-04-10 18:26                                     ` [patch] e1000=y && e1000e=m regression fix Kok, Auke
2008-04-10 21:20                                       ` Chris Friesen
2008-04-10 19:27                                   ` [patch] e1000=y && e1000e=m regression fix (was: Re: [regression] e1000e broke e1000) Linus Torvalds
2008-04-10 21:35                                 ` Krzysztof Halasa
2008-04-08 20:31               ` [regression] e1000e broke e1000 Kok, Auke
2008-04-09 19:12                 ` Ingo Molnar
2008-04-09 19:33                   ` Jeff Garzik
2008-04-11 11:30                     ` Ingo Molnar
2008-04-11 15:40                       ` Chris Friesen
2008-04-11 19:29                         ` Willy Tarreau
2008-04-10  0:52           ` Bill Davidsen
2008-04-11  8:59             ` Ingo Molnar
2008-04-08 19:43       ` [regression] e1000e broke e1000 (was: Re: [ANNOUNCE] e1000 toe1000e migration of PCI Express devices) Brandeburg, Jesse
2008-04-08 19:59         ` Ingo Molnar
2008-04-08 20:04           ` Matthew Wilcox
2008-04-08 20:12             ` [regression] e1000e broke e1000 Dan Noe
2008-04-08 20:20               ` Matthew Wilcox
2008-04-08 20:35                 ` Ingo Molnar
2008-04-08 20:36                   ` Martin Mares
2008-04-08 20:39                 ` Dan Noe
2008-04-08 20:13             ` showing which hardware is unclaimed Rick Jones
2008-04-08 20:35               ` Martin Mares
2008-04-08 20:17             ` [regression] e1000e broke e1000 (was: Re: [ANNOUNCE] e1000 toe1000e migration of PCI Express devices) Ingo Molnar
2008-04-09 19:08   ` [ANNOUNCE] e1000 to e1000e migration of PCI Express devices Ingo Molnar
2008-04-09 19:38     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47FEB4C8.3020303@snapgear.com \
    --to=philipc@snapgear.com \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@linux.intel.com \
    --cc=auke-jan.h.kok@intel.com \
    --cc=bruce.w.allan@intel.com \
    --cc=davem@davemloft.net \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=greg@kroah.com \
    --cc=jeff@garzik.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=john.ronciak@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=matthew@wil.cx \
    --cc=mingo@elte.hu \
    --cc=netdev@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).