From: Andreas Steinmetz <ast@domdv.de>
To: netdev@vger.kernel.org
Cc: Sabrina Dubroca <sd@queasysnail.net>
Subject: [PATCH net-next 2/3 v2] macsec: remove superfluous zeroing of skb reference
Date: Tue, 02 Jul 2019 22:50:03 +0200 [thread overview]
Message-ID: <47a075ac95cbd4fcbb89f5ffc7e074eb503f3e5c.camel@domdv.de> (raw)
Remove superfluous zeroing of skb pointer for the RX_HANDLER_CONSUMED
case, since in that case, __netif_receive_skb_core will simply ignore
the value.
Signed-off-by: Andreas Steinmetz <ast@domdv.de>
--- a/drivers/net/macsec.c 2019-06-30 22:04:10.003613880 +0200
+++ b/drivers/net/macsec.c 2019-06-30 22:04:22.405822436 +0200
@@ -1215,7 +1215,6 @@
macsec_rxsc_put(rx_sc);
}
rcu_read_unlock();
- *pskb = NULL;
return RX_HANDLER_CONSUMED;
}
@@ -1239,7 +1238,6 @@
rcu_read_unlock();
- *pskb = NULL;
return RX_HANDLER_CONSUMED;
drop:
@@ -1249,7 +1247,6 @@
rcu_read_unlock();
drop_direct:
kfree_skb(skb);
- *pskb = NULL;
return RX_HANDLER_CONSUMED;
nosci:
reply other threads:[~2019-07-03 0:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47a075ac95cbd4fcbb89f5ffc7e074eb503f3e5c.camel@domdv.de \
--to=ast@domdv.de \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox