From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B34545304B9 for ; Thu, 1 Oct 2026 15:41:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790869297; cv=none; b=buF7Depse2wo22T+XopRtx/1CIsB2Q5L2u60efSiLccYrBdIUtML266EJwcZiz2Iozt4n4CyEqdgpAIPpnQEHvBujqolA7JTJ/mT3lIRQ56Tlj8AUX7bWQckoVIL0duvAw3D/bQx3pTdb6RBcNSfq8EPZ+TQ/J/3EGnHUcjXbV4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790869297; c=relaxed/simple; bh=1T8xmr4MRs1K3j3y5oIphPuEh0OlFxvQsp6Pm3flkh8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ls0CcG+TuxK7XoABzUy3jWC4IAm4f/WoU/Q3YdXIypSjEeTpxalh3kJcKGq2criyC8sehblBpm6hdZ8bs+9G0eHeuYSatwtXb66TfOP7pwvVyl9CaoaQPwRdaLllu07vJ1VI+f3uhZZY/UaMS0CtLcoSglPHNXQtTSdJWHEb9yg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JqvrWO88; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=haztn2Bx; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JqvrWO88"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="haztn2Bx" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 691DwtFg2008547 for ; Thu, 1 Oct 2026 15:41:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qdipUe3szRwP8xuz1ENYjFx/VNsMoOJDQRWi0Y0Wyzs=; b=JqvrWO88VHVsMk9U J/h+jWsXTyObVyTC7PAe1QXm7rIsT4mUYUm8B3i8CeNEvMwzJJ2LSK0R3nafhQtd uQV3tQ8n5TJsXoUkxuM1CPz+G8vI1qwR/rsI7jy+fodoxkp+Znn2F9eO+GrapoL6 IhjYFgmtwdRHmQCcxjcjKn8qCCQj6VB12UBsmpee4Rfo1Cy+6YFyQNrcGe/JIKUQ bUuBzdIy5dfkjGnOJbq+I76/53aQgls1LtGnyokh1dFYFEhVJQQIPOUpGd1fqGjU Rqm3K1rtL4uSQtvvLhESajSHVtbE/MUF8Jhg3yFZM+Co5InKiJ1By03g80sTGiIw 41kAxA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h1rvq8gbk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 01 Oct 2026 15:41:33 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cec4226c70so54454935ad.1 for ; Thu, 01 Oct 2026 08:41:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790869293; x=1791474093; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qdipUe3szRwP8xuz1ENYjFx/VNsMoOJDQRWi0Y0Wyzs=; b=haztn2Bx66oIF5vSPDELb/tzltx8BDbd/gPzo34A9oP+RqqiO9sB5Mw9uoFIsNA9Qz 1tmVlzfp09MHnRHUV9BxbG9C8+AEvvInpQD7Om31AffQCVdUS/3Gajv02HBIQhMDvSew r2Yivfcqa29opM/ziWXgB8XhB2CcvrSknruDxolmP5QMEbwr2WuTkq7mMxGAOn9qDGp7 1MSZHa45mCvs9EXPXP6ZnBCk0mkHf1mcYI7v2pyCUm2RJS7ixlLrr9+TvU3XByrwBjJ5 VkBBI3p6PxL4nCmAAYRCtCJJpy4rK022F1iLeL6H7eb42OPgv5tmnTfgu0u5cZbSZJoB bmYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790869293; x=1791474093; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qdipUe3szRwP8xuz1ENYjFx/VNsMoOJDQRWi0Y0Wyzs=; b=iD9vJHv9Nq1vMg2C1CO/ybcc+lMbtb8zjQlmd3qmGJfrAhqXy+wTmHGrBmrM+XvUnn pvgY/uk6+kJIobW1JYFL27VMq/6VBw3xXEMJ+J+0K0BPfyNrVLgbPGE0NkYagm6PfPyh EfLBaS2zTIzHQXgii3XSNp/w5hSvcTa3/y0BlZgwER4HKVsdiMMQ88HXGyQ/emW66BYe apt0sglYxK/xRRo20PKhCsZybO+X+Yrb516oaWkSMmp2FCB/C5SilpEj9jWSEKhKKQh0 gXlC/lLqaGjoI7AkWEbgC0f0kvMxl9t+KMXfSAslb4yqJfZo9nLOixWl4Xa2Okpvsr2p wSvQ== X-Forwarded-Encrypted: i=1; AKwUvByoJbjsASHUh3Op0V2RHe1s9vavf52Gy8BtX+p7e9G5OljQ6XCytPLm89R7Ac6SW4979oq4l88=@vger.kernel.org X-Gm-Message-State: AFq9FYLVIfHs2pY9bIdRNxqsSiPRuKheZASZi+HMIHNLg8AnnlJeUAj7 /XA47CZQeaAztCXzT7OQ5q9oOfWJ37kLsp9hdon2il9ucDzOIRuP80Aq09qm7SCUFzcwGUkG3A7 GekcmzHxv4/iuiV1aaeMsZyoT5OM4vAsZdue1LBqgOEdNnjwI/2NDAqgB/lQ= X-Gm-Gg: AYBFou0A84DqV8EA/2mo3m4IldbCeMQ7OezaTVBvWmuMjrt3OOhMPNSEP3xHttyxJnW Ia63WRx1PQlLuauU2GnLoAvfGRD3qSfGVf57Nl338GmSVf2FRfrhqTXyCxS//IIr369RkL/tCJq 4qOn7P7JR7fXCsDNZ385rZ+NnYAcxcZEkO6C2/lauaBTM7SexB4hjN+cwH95tcfD0AgLKjUQQWO gokKgfl2XLq0zSc3Yhgg+lurYcJUqe5dw13M72Va9CljEHFbrM3jhLEXbiYolkDLfTXpmKQmyuc rKFAG5KJsqVk5b6lGTcTvSA4vm7G4RluizRlyHxKDUWTikj5DIlnVo1Pf8HxrqbFqktNjEstJwH yDlfJIH/u2cwZB7IPhLk+ohwdF/RhCAw+wSD2 X-Received: by 2002:a17:903:2f90:b0:2dd:ad73:c98d with SMTP id d9443c01a7336-2e2e4b4c6b6mr40600315ad.37.1790869291508; Thu, 01 Oct 2026 08:41:31 -0700 (PDT) X-Received: by 2002:a17:903:2f90:b0:2dd:ad73:c98d with SMTP id d9443c01a7336-2e2e4b4c6b6mr40600035ad.37.1790869290901; Thu, 01 Oct 2026 08:41:30 -0700 (PDT) Received: from [192.168.0.116] ([124.123.146.251]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e300b0834esm12975265ad.51.2026.10.01.08.41.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Oct 2026 08:41:30 -0700 (PDT) Message-ID: <47a155fc-9cde-48fd-bb02-31a7d3d9e8dd@oss.qualcomm.com> Date: Thu, 1 Oct 2026 21:11:22 +0530 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: qcom,bam-dmux: Add memory-region and qcom,vmid properties To: netdev-bot+sashiko@kernel.org Cc: stephan@gerhold.net, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, loic.poulain@oss.qualcomm.com, ryazanov.s.a@gmail.com, johannes@sipsolutions.net, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, deepak.singh@oss.qualcomm.com References: <20260920-qcom-bam-dmux-vmid-ext-v2-1-ef5ca2178378@oss.qualcomm.com> <178996250211.2160803.6013516663876593386@kernel.org> Content-Language: en-US From: Vishnu Santhosh In-Reply-To: <178996250211.2160803.6013516663876593386@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDAxMDA2MiBTYWx0ZWRfX8FYTIiar0VN8 bloYNkBihwfMt4TXJ6OlIVOMNlcCN7wX6hR5w+zPowweay+g5C1PZn3kQrjobL95WM1R2IyItWp 12APve+xSheVy1zEiSAoqNiZQmUsxibQUe0nhcoXVeMoj6WiKySoPSXMU42xl4YIZ7oEMTkZf9U SkPGpPLr4yRd8gIgWVrOX74ZkW1fvo+YP8lsK/RdzMXLYroUGAp6o+bRSwgRLcbGpEEpBV2OMn5 UEUnlNMxknMP0JUbIOOXaMCzpwXVJKkRz75LF1x3NxSgrRHnMTy797f5a8lkYHVfBMt2DaaKNhf 63NlkjZQ9YO+LtgtpxuyuMKJMvc/b3y0DKgV0i3FxRz3zlEWgGgiJ9gxR6LYFe4y/qcIIsixOCW FLsYuLIxb1BvHQfcJEEpEjfci9lVkiqpQngSZmYjIPRNh/zgmLaZJSAz3zhRaOZn5ZqHLgSHjEy qvPPqjvrNTf++XsTx0w== X-Authority-Analysis: v=2.4 cv=JIauIMKb c=1 sm=1 tr=0 ts=6abe7f2d cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=K/78aEDNEn2Q/Yuv7mVN5Q==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=Xq0XWdt-4rZHMzWQs8gA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: 6xTlKbadtZBzCvJiiPSuOLrir4B58ucH X-Proofpoint-ORIG-GUID: 6xTlKbadtZBzCvJiiPSuOLrir4B58ucH X-Proofpoint-Spam-Info: AW1haW4tMjYxMDAxMDA2MiBTYWx0ZWRfX1uUyfQ25a0nZ 9jbGXSQyQj7EEyH8yBFQrR2sbmRCtNIzIP9zrGRwX02SVzQqG5w3g2VHakf1LcBEzgS1hNWpdvG OT2NsYH1ftU3oYpWf4u7iJu+2o3vkmc= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-01_04,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 phishscore=0 impostorscore=0 bulkscore=0 spamscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2610010062 On 21-09-2026 09:18 am, netdev-bot+sashiko@kernel.org wrote: > Thank you for your contribution! Sashiko AI review found more severe > issue(s) in other patches of this series. This mail is only an FYI, in case > you want to address the nit picks below when you respin. > > Low priority / nit picks for your consideration: > > - [Low] SERIES-RESOLVED (retained for policy combination only): the > concern that the newly documented `qcom,vmid`/`memory-region`… > - [Low] The `qcom,vmid` schema contradicts its own description: the > description states "The local execution environment is retained… > > -- > > dt-bindings: net: qcom,bam-dmux: Add memory-region and qcom,vmid properties > > This adds an optional memory-region property pointing at a > restricted-dma-pool reserved-memory node for BAM-DMUX DMA mappings, plus a > qcom,vmid property naming the remote execution environment that is granted > access to that pool via SCM. A dependency entry makes memory-region > mandatory whenever qcom,vmid is present. > >> diff --git a/Documentation/devicetree/bindings/net/qcom,bam-dmux.yaml b/Documentation/devicetree/bindings/net/qcom,bam-dmux.yaml >> index 33746c238513..5351269b0ab7 100644 >> --- a/Documentation/devicetree/bindings/net/qcom,bam-dmux.yaml >> +++ b/Documentation/devicetree/bindings/net/qcom,bam-dmux.yaml >> @@ -72,6 +72,24 @@ properties: >> - const: tx >> - const: rx >> >> + memory-region: >> + maxItems: 1 >> + description: >> + Phandle to a reserved-memory node compatible with restricted-dma-pool. >> + The BAM-DMUX device uses the pool for DMA mappings. >> + > [Severity: Low] > This isn't a bug, just a note for the record on an earlier concern that > these two properties have no in-tree consumer. > > The companion patch in this series, "net: wwan: qcom_bam_dmux: Assign > restricted DMA pool to remote processor", adds bam_dmux_assign_dma_pool() > in drivers/net/wwan/qcom_bam_dmux.c, which reads qcom,vmid, resolves > memory-region through of_parse_phandle() and of_reserved_mem_lookup(), and > then performs the grant: > > ret = qcom_scm_assign_mem(rmem->base, rmem->size, &src, dst, > ARRAY_SIZE(dst)); > > The pool attachment itself is handled generically by > of_dma_set_restricted_buffer() from of_dma_configure_id(), so the > "uses the pool for DMA mappings" wording is backed by existing code too. > Nothing further appears to be needed here. > >> + qcom,vmid: >> + $ref: /schemas/types.yaml#/definitions/uint32-array >> + minItems: 1 >> + maxItems: 1 >> + items: >> + minimum: 1 >> + maximum: 63 >> + description: >> + VMID of the remote execution environment that is granted access to the >> + restricted DMA pool through SCM. The local execution environment is >> + retained automatically and must not be specified. >> + > [Severity: Low] > Does the numeric constraint on qcom,vmid contradict its own description? > > The description says the local execution environment "must not be > specified", but the only constraints are minimum 1 and maximum 63, and > include/dt-bindings/firmware/qcom,scm.h has: > > #define QCOM_SCM_VMID_HLOS 0x3 > > So qcom,vmid = passes dt_binding_check even though the > binding text declares it invalid. The 1..63 range looks like it encodes the > width of the SCM VMID bitmask used for BIT_ULL(vmid) in a u64, not the set > of values meaningful for this device. > > The driver side in this series does enforce the rule, in > bam_dmux_assign_dma_pool(): > > if (vmid == QCOM_SCM_VMID_HLOS || vmid >= BITS_PER_TYPE(u64)) > return dev_err_probe(dev, -EINVAL, "Invalid qcom,vmid %u\n", vmid); > > so the outcome of a bad value is a probe failure rather than anything worse. > Would it make sense to encode the same restriction in the schema, for > example with a not/const 3 clause or an enum of the supported remote > execution environments, or otherwise drop the "must not be specified" > sentence so the prose and the schema agree? I plan to drop the "must not be specified" sentence in the next revision, so the prose and the schema agree. Thanks, Vishnu > > For context, neither qcom,rmtfs-mem.yaml nor qcom,fastrpc.yaml places value > constraints on their qcom,vmid / qcom,vmids properties, so an enum here > would be a new convention rather than an existing one; the narrow point is > just the internal inconsistency in this file. > > [ ... ] >