From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-lf0-f67.google.com ([209.85.215.67]:45404 "EHLO
        mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751427AbeCWQSN (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 23 Mar 2018 12:18:13 -0400
Received: by mail-lf0-f67.google.com with SMTP id l4-v6so14776707lfg.12
        for <netdev@vger.kernel.org>; Fri, 23 Mar 2018 09:18:12 -0700 (PDT)
Subject: Re: [bpf-next V5 PATCH 09/15] mlx5: register a memory model when XDP
 is enabled
To: Jesper Dangaard Brouer <brouer@redhat.com>, netdev@vger.kernel.org,
        =?UTF-8?B?QmrDtnJuVMO2cGVs?= <bjorn.topel@intel.com>,
        magnus.karlsson@intel.com
Cc: eugenia@mellanox.com, Jason Wang <jasowang@redhat.com>,
        John Fastabend <john.fastabend@gmail.com>,
        Eran Ben Elisha <eranbe@mellanox.com>,
        Saeed Mahameed <saeedm@mellanox.com>, galp@mellanox.com,
        Daniel Borkmann <borkmann@iogearbox.net>,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        Tariq Toukan <tariqt@mellanox.com>
References: <152180742196.20167.5168801400337773178.stgit@firesoul>
 <152180752460.20167.1098864148126196703.stgit@firesoul>
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Message-ID: <47a5c085-bffc-0e01-c751-c0e228661eac@cogentembedded.com>
Date: Fri, 23 Mar 2018 19:18:09 +0300
MIME-Version: 1.0
In-Reply-To: <152180752460.20167.1098864148126196703.stgit@firesoul>
Content-Type: text/plain; charset=utf-8
Content-Language: en-MW
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hello!

On 03/23/2018 03:18 PM, Jesper Dangaard Brouer wrote:

> Now all the users of ndo_xdp_xmit have been converted to use xdp_return_frame.
> This enable a different memory model, thus activating another code path
> in the xdp_return_frame API.
> 
> V2: Fixed issues pointed out by Tariq.
> 
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
> Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en_main.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> index da94c8cba5ee..2e4ca0f15b62 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> @@ -506,6 +506,14 @@ static int mlx5e_alloc_rq(struct mlx5e_channel *c,
>  		rq->mkey_be = c->mkey_be;
>  	}
>  
> +	/* This must only be activate for order-0 pages */

   Activated?

[...]

MBR, Sergei