From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E464C282C7 for ; Sat, 26 Jan 2019 14:08:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D268214C6 for ; Sat, 26 Jan 2019 14:08:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sl/3zpiP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726156AbfAZOId (ORCPT ); Sat, 26 Jan 2019 09:08:33 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:40828 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725987AbfAZOIc (ORCPT ); Sat, 26 Jan 2019 09:08:32 -0500 Received: by mail-wr1-f66.google.com with SMTP id p4so13109883wrt.7 for ; Sat, 26 Jan 2019 06:08:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+/rN5uv8PUU1WSoQgZojjVcimI6cDEcIzDZGXqsKDtA=; b=sl/3zpiPyW9/UGins8HohM6Nf0qoSiehz0XRSmaAf+3J9aYVFNvI6e4UEl/Q5UFgY3 L6mBJNgkSmWYQ/h30lS45HBjD5Dl71lxd1Q7n2Rgfpc/qphB/AVko5fbWjvpYr0JQ1he TVY2KJITIuxvEm8E1WnsM1SsI3JX9B4K9Bqm6nmpvZ1IXv5ieWXNkb0IKrkyMW0uzwj7 UjNbG8rZZmjMQ4p+FxXKCU/qL3pcoIgedmEbkHAjgofAO+97WtxBdJgnXNYkOVpD2dFd sZUKKa4jDF7bHAEvd9F15PZEDVGgM/ShzXtQ+IpkchUe3nDjgpqcCKjl+yiIIqizQHcv vUGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+/rN5uv8PUU1WSoQgZojjVcimI6cDEcIzDZGXqsKDtA=; b=KRjUrg7gYbZ+ZWQuFHW4hNbmYD8TeJ8H9I6LYMgED7lD3BthYj8Iw9ubqN7Q8EhaZ/ osCwzPKCTfoE8dMsihcRse7szXGNb1OGd2Rls30dH1iw7NbGJ/3M8nKQEaKZHblBOJi9 VI5P3unf+6UHym3prxqRC7FrDW+wJ9ESSvWhFWcZlnDFb0gf+BHvZA1V1XaXJMYEwMeO laFNbuE0ldiXtaoS4j2ZQJjGPCwF/2c3GvdOhLIRXHLNnyaGQjBAtfBjTA2ijxr3fwYd uRDRMlo+mvKyUbaghtChu/+gZ6Rcmu3llzWg2i1YnZWuAdfAXpKaj3DacYtafbN+fPmu gE6g== X-Gm-Message-State: AJcUukdhKQGBcSDGN59yZpb822zFYS7gg5lpEUiNOoWG/pHtm6t1gmFt IDd/xdSSObQsFhsEjnTgNTMe2z7B X-Google-Smtp-Source: ALg8bN7uXpZ1SHfyT6T4Ep84Gneotx4/ev8GaV5aPS40Xkk4oY9ek6Hpcv+oWvIWe7zjpvw8XDIi0g== X-Received: by 2002:adf:93e2:: with SMTP id 89mr15788210wrp.129.1548511710501; Sat, 26 Jan 2019 06:08:30 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:e416:5520:9c93:d4eb? (p200300EA8BF1E200E41655209C93D4EB.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:e416:5520:9c93:d4eb]) by smtp.googlemail.com with ESMTPSA id t66sm35852813wme.15.2019.01.26.06.08.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 26 Jan 2019 06:08:29 -0800 (PST) Subject: Re: WoL broken in r8169.c since kernel 4.19 To: Marc Haber Cc: "netdev@vger.kernel.org" References: <20190112200831.GB20268@torres.zugschlus.de> <20190113160149.GG20268@torres.zugschlus.de> From: Heiner Kallweit Message-ID: <47a81eb9-64bf-9477-f268-1fc35ee39cd9@gmail.com> Date: Sat, 26 Jan 2019 15:08:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190113160149.GG20268@torres.zugschlus.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 13.01.2019 17:01, Marc Haber wrote: > On Sat, Jan 12, 2019 at 09:28:48PM +0100, Heiner Kallweit wrote: >> On 12.01.2019 21:08, Marc Haber wrote: >>> I am writing to all people who have commits in r8169.c between the v4.18 >>> and v4.19 tags in the Linux kernel. Please ignore as appropriate. If >>> you'd prefer that to be on a mailing list, please indicate on which list >>> you want to have that, and I'll resend. >>> >> It should be cc'ed to the netdev mailing list, as listed in MAINTAINERS. > > I have bounced the original message there. Sorry for missing that, I was > not aware that the MAINTAINERS file goes down on a single driver level. > >>> My desktop copmuter has the following network interface: >>> >>> 06:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller (rev 06) >>> Subsystem: ASUSTeK Computer Inc. P8P67 and other motherboards >>> Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx+ >>> Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- SERR- >> Latency: 0, Cache Line Size: 64 bytes >>> Interrupt: pin A routed to IRQ 17 >>> NUMA node: 0 >>> Region 0: I/O ports at e800 [size=256] >>> Region 2: Memory at fdfff000 (64-bit, prefetchable) [size=4K] >>> Region 4: Memory at fdff8000 (64-bit, prefetchable) [size=16K] >>> Capabilities: >>> Kernel driver in use: r8169 >>> Kernel modules: r8169 >>> >> Unfortunately there's different chip versions with the same description. >> Please provide the result of "dmesg | grep XID". > > [1/5004]mh@fan:~ $ dmesg | grep XID > [ 2.671004] r8169 0000:06:00.0 eth0: RTL8168evl/8111evl, 54:04:a6:82:21:00, XID 2c900800, IRQ 29 > >>> I regularly buíld a VPN tunnel to my local network from 'on the road' >>> and use WoL to wake up the desktop box when I need it. >>> >>> Since kernel 4.19, that does not work any more, the desktop remains >>> suspended when I send it a magic packet. This still applies to 4.20.1, >>> and it still works with any 4.18 kernel. >>> >> WoL works perfectly fine here with r8169 from runtime-suspend and >> from S3. How do you enable WoL? And which WoL method do you use >> (magic packet or ..) ? > > I do enable WOL via systemd-networkd: > [7/5009]mh@fan:~ $ cat /etc/systemd/network/10-lanc0.link > [Match] > MACAddress=54:04:a6:82:21:00 > > [Link] > Name=lanc0 > WakeOnLan=magic > > and I wake up the box by calling > > sudo etherwake -i int182 54:04:a6:82:21:00 > > on the router. int182 is the interface name of the correct interface, > this is proven correct by the fact that the box wakes up just fine with > older version of the driver. > >> Please provide a register dump (ethtool -d ). > > The register dump is here (obtained with 4.20.1 with the r8169.c from > 4.18): > [5/5008]mh@fan:~ $ sudo ethtool -d lanc0 Just one more thing because this register dump was with the r8169 driver from 4.18 which is known to work. Can you provide a register dump from a 4.20 r8169 which suffers from the issue?