From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EAC3C43381 for ; Sun, 17 Feb 2019 09:32:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D8EC02192D for ; Sun, 17 Feb 2019 09:32:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W0+iqutn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727435AbfBQJcq (ORCPT ); Sun, 17 Feb 2019 04:32:46 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:33283 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726895AbfBQJcp (ORCPT ); Sun, 17 Feb 2019 04:32:45 -0500 Received: by mail-wm1-f65.google.com with SMTP id h22so9842435wmb.0 for ; Sun, 17 Feb 2019 01:32:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=b8YMPJVwvniifgSrSgoAmBO7PLGeNgb8ceE/YpCcqz0=; b=W0+iqutnHFIaulm9DkyusfbseTjskU4hg3/15wzVpqP/VLgNw0jh/WIUXhjNJ0KXyC oUA60XthxTov1OvzQHGxkrIsh5RbSL34TArSNEJ+kaiHbntKT68tRTGGlOTMOSsjvBBV obDVSPGv2NqkPiRoXtPfoYo2E2MVB06k4eXiOYLDTO06/JcAZNv5BwRUx3DeP5Si3iao 4UgbEPP7jYLdIZoSSnYBcRmOuHKuWuuNy0rDbzvsBo3job0dIr1r5w1ApJzPVwmPiJvT A3Zbun8LCuHCrdOv2BqD6JEYi3ee/e4fdilxf4MY0+lvCcVR9sTLLdnd2dF3ilG7lTg0 QBqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=b8YMPJVwvniifgSrSgoAmBO7PLGeNgb8ceE/YpCcqz0=; b=EkdenFHgDjNtsSp3/1vYGk+lkf2CxgQLZONzY7FW5uNUSsQ2mT0wJg43AsVM0BuamW WtiWWuUelohQRKGPoakqnuhw8CyvjPGhSHEVzEIgbpOAI5Z6r3knjnz73Mkneh8g71Ze 1umv4WJ+VoSgNhE5SWFUw1mSX8MYOKmDjRf65+Alj2VaMq4Mw9sWUpxgNJREcW3+vpVq Bn7aFNldSR8+Mp5SBFtkzjZOLOWusz5Pswx/vpNbUuZDrRi9evvzQCU7BBYSCcr6NNgh igg1hXvaT0hK0XBNPG4AWpYaW+6WQOyzza1nPxFG4ZFrN1387YZmGmFPMXK+QTrxYefM 3UtQ== X-Gm-Message-State: AHQUAuZTGrl/qj3CeVp21JAzCHbcYdJROTEZh/jaJBzDwNwErRRaULAI 6Cuegpt9OKGnST2kKZwFPBUiA6sV X-Google-Smtp-Source: AHgI3IbCnl9cBYfQ92ZWbkCCwYTt8qQdFacNUAqWnTEgvH4E30SZwvPHoRESTO2DZ2DkY9MXkk0rsQ== X-Received: by 2002:a7b:cb82:: with SMTP id m2mr13194277wmi.135.1550395963993; Sun, 17 Feb 2019 01:32:43 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:4c36:c930:69b6:c10f? (p200300EA8BF1E2004C36C93069B6C10F.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:4c36:c930:69b6:c10f]) by smtp.googlemail.com with ESMTPSA id u15sm14267374wmu.17.2019.02.17.01.32.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Feb 2019 01:32:43 -0800 (PST) Subject: [PATCH net-next v3 2/4] net: phy: add genphy_c45_an_config_aneg From: Heiner Kallweit To: Andrew Lunn , Florian Fainelli , David Miller , Russell King - ARM Linux Cc: "netdev@vger.kernel.org" References: <46898fe1-8924-0da0-1bbd-b54c220ff8d1@gmail.com> Message-ID: <47c75314-abba-12b8-afee-ec57ee033485@gmail.com> Date: Sun, 17 Feb 2019 10:29:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <46898fe1-8924-0da0-1bbd-b54c220ff8d1@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Andrew Lunn C45 configuration of 10/100 and multi-giga bit auto negotiation advertisement is standardized. Configuration of 1000Base-T however appears to be vendor specific. Move the generic code out of the Marvell driver into the common phy-c45.c file. v2: - change function name to genphy_c45_an_config_aneg Signed-off-by: Andrew Lunn [hkallweit1@gmail.com: use new helper linkmode_adv_to_mii_10gbt_adv_t and split patch] Signed-off-by: Heiner Kallweit Reviewed-by: Florian Fainelli --- drivers/net/phy/phy-c45.c | 44 +++++++++++++++++++++++++++++++++++++++ include/linux/phy.h | 1 + 2 files changed, 45 insertions(+) diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c index 98a04d4cd..16636d49b 100644 --- a/drivers/net/phy/phy-c45.c +++ b/drivers/net/phy/phy-c45.c @@ -78,6 +78,50 @@ int genphy_c45_pma_setup_forced(struct phy_device *phydev) } EXPORT_SYMBOL_GPL(genphy_c45_pma_setup_forced); +/** + * genphy_c45_an_config_aneg - configure advertisement registers + * @phydev: target phy_device struct + * + * Configure advertisement registers based on modes set in phydev->advertising + * + * Returns negative errno code on failure, 0 if advertisement didn't change, + * or 1 if advertised modes changed. + */ +int genphy_c45_an_config_aneg(struct phy_device *phydev) +{ + int changed = 0, ret; + u32 adv; + + linkmode_and(phydev->advertising, phydev->advertising, + phydev->supported); + + adv = linkmode_adv_to_mii_adv_t(phydev->advertising); + + ret = phy_modify_mmd(phydev, MDIO_MMD_AN, MDIO_AN_ADVERTISE, + ADVERTISE_ALL | ADVERTISE_100BASE4 | + ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM, + adv); + if (ret < 0) + return ret; + if (ret > 0) + changed = 1; + + adv = linkmode_adv_to_mii_10gbt_adv_t(phydev->advertising); + + ret = phy_modify_mmd(phydev, MDIO_MMD_AN, MDIO_AN_10GBT_CTRL, + MDIO_AN_10GBT_CTRL_ADV10G | + MDIO_AN_10GBT_CTRL_ADV5G | + MDIO_AN_10GBT_CTRL_ADV2_5G, + adv); + if (ret < 0) + return ret; + if (ret > 0) + changed = 1; + + return changed; +} +EXPORT_SYMBOL_GPL(genphy_c45_an_config_aneg); + /** * genphy_c45_an_disable_aneg - disable auto-negotiation * @phydev: target phy_device struct diff --git a/include/linux/phy.h b/include/linux/phy.h index bf1070c2a..3db507e68 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -1101,6 +1101,7 @@ int genphy_c45_read_link(struct phy_device *phydev); int genphy_c45_read_lpa(struct phy_device *phydev); int genphy_c45_read_pma(struct phy_device *phydev); int genphy_c45_pma_setup_forced(struct phy_device *phydev); +int genphy_c45_an_config_aneg(struct phy_device *phydev); int genphy_c45_an_disable_aneg(struct phy_device *phydev); int genphy_c45_read_mdix(struct phy_device *phydev); int genphy_c45_pma_read_abilities(struct phy_device *phydev); -- 2.20.1