Re: [PATCH net] net: stmmac: Disable queues before netif_tx_disable in xdp_release

["Nazle Asmade, Muhammad Nazim Amirul" <muhammad.nazim.amirul.nazle.asmade@altera.com>]

On 27/7/2026 4:00 pm, Maxime Chevallier wrote:
> Hi,
>
> On 7/27/26 05:06, muhammad.nazim.amirul.nazle.asmade@altera.com wrote:
>> From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
>>
>> stmmac_xdp_release() calls netif_tx_disable() before
>> stmmac_disable_all_queues(), which creates a race window where NAPI
>> is still running while TX is being disabled. If a packet is still
>> queued at that point, it can be processed after TX is stopped,
>> leading to a kernel panic.
>>
>> Fix this by calling stmmac_disable_all_queues() first to stop NAPI
>> processing before disabling TX, matching the order already used in
>> stmmac_release() since 7028471edb64.
>>
>> Fixes: 7028471edb64 ("net: ethernet: stmicro: stmmac: first disable all queues and disconnect in release")
>> Signed-off-by: Rohan G Thomas <rohan.g.thomas@altera.com>
>> Signed-off-by: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
> Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
>
> Maxime


Hi Jakub,

Is this patch good to merge or require any attention on my end, please 
let me know if any :)

BR,

Nazim