* [PATCH] sky2: missing chip name for Yukon Supreme
@ 2008-04-10 20:06 Stephen Hemminger
2008-04-10 20:14 ` Christoph Hellwig
2008-04-12 5:53 ` Jeff Garzik
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Hemminger @ 2008-04-10 20:06 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev
Any usage of sky2 on new Yukon Supreme would cause a NULL dereference.
The chip is very new, so the support is still untested; vendor has
not sent any eval hardware.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
---
Please apply for 2.6.25
--- a/drivers/net/sky2.c 2008-04-10 14:01:05.000000000 -0500
+++ b/drivers/net/sky2.c 2008-04-10 14:04:23.000000000 -0500
@@ -154,6 +154,7 @@ static const char *yukon2_name[] = {
"EC", /* 0xb6 */
"FE", /* 0xb7 */
"FE+", /* 0xb8 */
+ "Supreme", /* 0xb9 */
};
static void sky2_set_multicast(struct net_device *dev);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] sky2: missing chip name for Yukon Supreme
2008-04-10 20:06 [PATCH] sky2: missing chip name for Yukon Supreme Stephen Hemminger
@ 2008-04-10 20:14 ` Christoph Hellwig
2008-04-10 20:21 ` Stephen Hemminger
2008-04-12 5:53 ` Jeff Garzik
1 sibling, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2008-04-10 20:14 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Jeff Garzik, netdev
On Thu, Apr 10, 2008 at 03:06:14PM -0500, Stephen Hemminger wrote:
> Any usage of sky2 on new Yukon Supreme would cause a NULL dereference.
> The chip is very new, so the support is still untested; vendor has
> not sent any eval hardware.
What about also making the driver not oops in case another variant is added?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sky2: missing chip name for Yukon Supreme
2008-04-10 20:14 ` Christoph Hellwig
@ 2008-04-10 20:21 ` Stephen Hemminger
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2008-04-10 20:21 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Jeff Garzik, netdev
On Thu, 10 Apr 2008 16:14:21 -0400
Christoph Hellwig <hch@infradead.org> wrote:
> On Thu, Apr 10, 2008 at 03:06:14PM -0500, Stephen Hemminger wrote:
> > Any usage of sky2 on new Yukon Supreme would cause a NULL dereference.
> > The chip is very new, so the support is still untested; vendor has
> > not sent any eval hardware.
>
> What about also making the driver not oops in case another variant is added?
Many more changes will be needed for the next new variant. They never do
the same thing.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sky2: missing chip name for Yukon Supreme
2008-04-10 20:06 [PATCH] sky2: missing chip name for Yukon Supreme Stephen Hemminger
2008-04-10 20:14 ` Christoph Hellwig
@ 2008-04-12 5:53 ` Jeff Garzik
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2008-04-12 5:53 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
Stephen Hemminger wrote:
> Any usage of sky2 on new Yukon Supreme would cause a NULL dereference.
> The chip is very new, so the support is still untested; vendor has
> not sent any eval hardware.
>
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
> ---
> Please apply for 2.6.25
>
> --- a/drivers/net/sky2.c 2008-04-10 14:01:05.000000000 -0500
> +++ b/drivers/net/sky2.c 2008-04-10 14:04:23.000000000 -0500
> @@ -154,6 +154,7 @@ static const char *yukon2_name[] = {
> "EC", /* 0xb6 */
> "FE", /* 0xb7 */
> "FE+", /* 0xb8 */
> + "Supreme", /* 0xb9 */
> };
>
> static void sky2_set_multicast(struct net_device *dev);
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
applied
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-04-12 5:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-10 20:06 [PATCH] sky2: missing chip name for Yukon Supreme Stephen Hemminger
2008-04-10 20:14 ` Christoph Hellwig
2008-04-10 20:21 ` Stephen Hemminger
2008-04-12 5:53 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).