From: Jeff Garzik <jeff@garzik.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: Haavard Skinnemoen <hskinnemoen@atmel.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] macb: Use semicolon instead of comma for statement
Date: Sat, 12 Apr 2008 03:01:56 -0400 [thread overview]
Message-ID: <48005E64.1090401@garzik.org> (raw)
In-Reply-To: <20080412.005814.26099357.anemo@mba.ocn.ne.jp>
Atsushi Nemoto wrote:
> It seems no good reason to use comma here.
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> ---
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index 1d210ed..0881690 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -242,12 +242,12 @@ static int macb_mii_init(struct macb *bp)
> /* Enable managment port */
> macb_writel(bp, NCR, MACB_BIT(MPE));
>
> - bp->mii_bus.name = "MACB_mii_bus",
> - bp->mii_bus.read = &macb_mdio_read,
> - bp->mii_bus.write = &macb_mdio_write,
> - bp->mii_bus.reset = &macb_mdio_reset,
> - bp->mii_bus.id = bp->pdev->id,
> - bp->mii_bus.priv = bp,
> + bp->mii_bus.name = "MACB_mii_bus";
> + bp->mii_bus.read = &macb_mdio_read;
> + bp->mii_bus.write = &macb_mdio_write;
> + bp->mii_bus.reset = &macb_mdio_reset;
> + bp->mii_bus.id = bp->pdev->id;
> + bp->mii_bus.priv = bp;
> bp->mii_bus.dev = &bp->dev->dev;
> pdata = bp->pdev->dev.platform_data;
>
applied
next prev parent reply other threads:[~2008-04-12 7:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-11 15:58 [PATCH] macb: Use semicolon instead of comma for statement Atsushi Nemoto
2008-04-12 7:01 ` Jeff Garzik [this message]
2008-04-16 5:05 ` Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48005E64.1090401@garzik.org \
--to=jeff@garzik.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=hskinnemoen@atmel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).