* [PATCH] macb: Use semicolon instead of comma for statement
@ 2008-04-11 15:58 Atsushi Nemoto
2008-04-12 7:01 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Atsushi Nemoto @ 2008-04-11 15:58 UTC (permalink / raw)
To: Haavard Skinnemoen; +Cc: Jeff Garzik, netdev
It seems no good reason to use comma here.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
diff --git a/drivers/net/macb.c b/drivers/net/macb.c
index 1d210ed..0881690 100644
--- a/drivers/net/macb.c
+++ b/drivers/net/macb.c
@@ -242,12 +242,12 @@ static int macb_mii_init(struct macb *bp)
/* Enable managment port */
macb_writel(bp, NCR, MACB_BIT(MPE));
- bp->mii_bus.name = "MACB_mii_bus",
- bp->mii_bus.read = &macb_mdio_read,
- bp->mii_bus.write = &macb_mdio_write,
- bp->mii_bus.reset = &macb_mdio_reset,
- bp->mii_bus.id = bp->pdev->id,
- bp->mii_bus.priv = bp,
+ bp->mii_bus.name = "MACB_mii_bus";
+ bp->mii_bus.read = &macb_mdio_read;
+ bp->mii_bus.write = &macb_mdio_write;
+ bp->mii_bus.reset = &macb_mdio_reset;
+ bp->mii_bus.id = bp->pdev->id;
+ bp->mii_bus.priv = bp;
bp->mii_bus.dev = &bp->dev->dev;
pdata = bp->pdev->dev.platform_data;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] macb: Use semicolon instead of comma for statement
2008-04-11 15:58 [PATCH] macb: Use semicolon instead of comma for statement Atsushi Nemoto
@ 2008-04-12 7:01 ` Jeff Garzik
2008-04-16 5:05 ` Haavard Skinnemoen
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2008-04-12 7:01 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: Haavard Skinnemoen, netdev
Atsushi Nemoto wrote:
> It seems no good reason to use comma here.
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> ---
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index 1d210ed..0881690 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -242,12 +242,12 @@ static int macb_mii_init(struct macb *bp)
> /* Enable managment port */
> macb_writel(bp, NCR, MACB_BIT(MPE));
>
> - bp->mii_bus.name = "MACB_mii_bus",
> - bp->mii_bus.read = &macb_mdio_read,
> - bp->mii_bus.write = &macb_mdio_write,
> - bp->mii_bus.reset = &macb_mdio_reset,
> - bp->mii_bus.id = bp->pdev->id,
> - bp->mii_bus.priv = bp,
> + bp->mii_bus.name = "MACB_mii_bus";
> + bp->mii_bus.read = &macb_mdio_read;
> + bp->mii_bus.write = &macb_mdio_write;
> + bp->mii_bus.reset = &macb_mdio_reset;
> + bp->mii_bus.id = bp->pdev->id;
> + bp->mii_bus.priv = bp;
> bp->mii_bus.dev = &bp->dev->dev;
> pdata = bp->pdev->dev.platform_data;
>
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-04-16 5:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-11 15:58 [PATCH] macb: Use semicolon instead of comma for statement Atsushi Nemoto
2008-04-12 7:01 ` Jeff Garzik
2008-04-16 5:05 ` Haavard Skinnemoen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).