From: Jeff Garzik <jeff@garzik.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: Haavard Skinnemoen <hskinnemoen@atmel.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] macb: Call phy_disconnect on removing
Date: Sat, 12 Apr 2008 03:02:06 -0400 [thread overview]
Message-ID: <48005E6E.3010802@garzik.org> (raw)
In-Reply-To: <20080410.233007.41197293.anemo@mba.ocn.ne.jp>
Atsushi Nemoto wrote:
> Call phy_disconnect() on remove routine. Otherwise the phy timer
> causes a kernel crash when unloading.
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> ---
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index 1d210ed..10fcea5 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -1257,6 +1257,8 @@ static int __exit macb_remove(struct platform_device *pdev)
>
> if (dev) {
> bp = netdev_priv(dev);
> + if (bp->phy_dev)
> + phy_disconnect(bp->phy_dev);
> mdiobus_unregister(&bp->mii_bus);
> kfree(bp->mii_bus.irq);
applied
next prev parent reply other threads:[~2008-04-12 7:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 14:30 [PATCH] macb: Call phy_disconnect on removing Atsushi Nemoto
2008-04-12 7:02 ` Jeff Garzik [this message]
2008-04-15 8:53 ` Andrew Morton
2008-04-15 16:35 ` Atsushi Nemoto
2008-04-16 4:57 ` Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48005E6E.3010802@garzik.org \
--to=jeff@garzik.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=hskinnemoen@atmel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).