* [PATCH] macb: Call phy_disconnect on removing
@ 2008-04-10 14:30 Atsushi Nemoto
2008-04-12 7:02 ` Jeff Garzik
0 siblings, 1 reply; 5+ messages in thread
From: Atsushi Nemoto @ 2008-04-10 14:30 UTC (permalink / raw)
To: Haavard Skinnemoen; +Cc: Jeff Garzik, netdev
Call phy_disconnect() on remove routine. Otherwise the phy timer
causes a kernel crash when unloading.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
diff --git a/drivers/net/macb.c b/drivers/net/macb.c
index 1d210ed..10fcea5 100644
--- a/drivers/net/macb.c
+++ b/drivers/net/macb.c
@@ -1257,6 +1257,8 @@ static int __exit macb_remove(struct platform_device *pdev)
if (dev) {
bp = netdev_priv(dev);
+ if (bp->phy_dev)
+ phy_disconnect(bp->phy_dev);
mdiobus_unregister(&bp->mii_bus);
kfree(bp->mii_bus.irq);
unregister_netdev(dev);
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] macb: Call phy_disconnect on removing
2008-04-10 14:30 [PATCH] macb: Call phy_disconnect on removing Atsushi Nemoto
@ 2008-04-12 7:02 ` Jeff Garzik
2008-04-15 8:53 ` Andrew Morton
0 siblings, 1 reply; 5+ messages in thread
From: Jeff Garzik @ 2008-04-12 7:02 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: Haavard Skinnemoen, netdev
Atsushi Nemoto wrote:
> Call phy_disconnect() on remove routine. Otherwise the phy timer
> causes a kernel crash when unloading.
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> ---
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index 1d210ed..10fcea5 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -1257,6 +1257,8 @@ static int __exit macb_remove(struct platform_device *pdev)
>
> if (dev) {
> bp = netdev_priv(dev);
> + if (bp->phy_dev)
> + phy_disconnect(bp->phy_dev);
> mdiobus_unregister(&bp->mii_bus);
> kfree(bp->mii_bus.irq);
applied
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] macb: Call phy_disconnect on removing
2008-04-12 7:02 ` Jeff Garzik
@ 2008-04-15 8:53 ` Andrew Morton
2008-04-15 16:35 ` Atsushi Nemoto
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Morton @ 2008-04-15 8:53 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Atsushi Nemoto, Haavard Skinnemoen, netdev
On Sat, 12 Apr 2008 03:02:06 -0400 Jeff Garzik <jeff@garzik.org> wrote:
> Atsushi Nemoto wrote:
> > Call phy_disconnect() on remove routine. Otherwise the phy timer
> > causes a kernel crash when unloading.
> >
> > Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> > ---
> > diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> > index 1d210ed..10fcea5 100644
> > --- a/drivers/net/macb.c
> > +++ b/drivers/net/macb.c
> > @@ -1257,6 +1257,8 @@ static int __exit macb_remove(struct platform_device *pdev)
> >
> > if (dev) {
> > bp = netdev_priv(dev);
> > + if (bp->phy_dev)
> > + phy_disconnect(bp->phy_dev);
> > mdiobus_unregister(&bp->mii_bus);
> > kfree(bp->mii_bus.irq);
>
> applied
>
Needed in 2.6.24.x as well, I think?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] macb: Call phy_disconnect on removing
2008-04-15 8:53 ` Andrew Morton
@ 2008-04-15 16:35 ` Atsushi Nemoto
2008-04-16 4:57 ` Haavard Skinnemoen
0 siblings, 1 reply; 5+ messages in thread
From: Atsushi Nemoto @ 2008-04-15 16:35 UTC (permalink / raw)
To: akpm; +Cc: jeff, hskinnemoen, netdev, stable
On Tue, 15 Apr 2008 01:53:31 -0700, Andrew Morton <akpm@linux-foundation.org> wrote:
> > applied
>
> Needed in 2.6.24.x as well, I think?
Yes, though I suppose this driver is not widely used as a module.
CC-ed to stable@kernel.org.
commit 84b7901f8d5a17536ef2df7fd628ab865df8fe3a
Author: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Thu Apr 10 23:30:07 2008 +0900
macb: Call phy_disconnect on removing
Call phy_disconnect() on remove routine. Otherwise the phy timer
causes a kernel crash when unloading.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
diff --git a/drivers/net/macb.c b/drivers/net/macb.c
index 1d210ed..10fcea5 100644
--- a/drivers/net/macb.c
+++ b/drivers/net/macb.c
@@ -1257,6 +1257,8 @@ static int __exit macb_remove(struct platform_device *pdev)
if (dev) {
bp = netdev_priv(dev);
+ if (bp->phy_dev)
+ phy_disconnect(bp->phy_dev);
mdiobus_unregister(&bp->mii_bus);
kfree(bp->mii_bus.irq);
unregister_netdev(dev);
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] macb: Call phy_disconnect on removing
2008-04-15 16:35 ` Atsushi Nemoto
@ 2008-04-16 4:57 ` Haavard Skinnemoen
0 siblings, 0 replies; 5+ messages in thread
From: Haavard Skinnemoen @ 2008-04-16 4:57 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: akpm, jeff, netdev, stable
On Wed, 16 Apr 2008 01:35:20 +0900 (JST)
Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> On Tue, 15 Apr 2008 01:53:31 -0700, Andrew Morton <akpm@linux-foundation.org> wrote:
> > > applied
> >
> > Needed in 2.6.24.x as well, I think?
>
> Yes, though I suppose this driver is not widely used as a module.
> CC-ed to stable@kernel.org.
Yes, I agree it's needed in -stable too. You're probably right that
this driver isn't widely used as a module -- I like to have at least
the possibility of running nfsroot on the kernels I build.
Thanks a lot, Atsushi, Jeff and Andrew for taking care of this while
I'm being unresponsive.
Haavard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-04-16 4:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-10 14:30 [PATCH] macb: Call phy_disconnect on removing Atsushi Nemoto
2008-04-12 7:02 ` Jeff Garzik
2008-04-15 8:53 ` Andrew Morton
2008-04-15 16:35 ` Atsushi Nemoto
2008-04-16 4:57 ` Haavard Skinnemoen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).