From: Jeff Garzik <jgarzik@pobox.com>
To: Andy Fleming <afleming@freescale.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2.6.26] phy: Change mii_bus id field to a string
Date: Sat, 12 Apr 2008 05:01:27 -0400 [thread overview]
Message-ID: <48007A67.3090806@pobox.com> (raw)
In-Reply-To: <1207787893-9200-1-git-send-email-afleming@freescale.com>
Andy Fleming wrote:
> Having the id field be an int was making more complex bus topologies
> excessively difficult. For now, just convert it to a string, and
> change all instances of "bus->id = val" to
> snprintf(id, MII_BUS_ID_LEN, "%x", val).
>
> Signed-off-by: Andy Fleming <afleming@freescale.com>
> ---
> arch/powerpc/platforms/82xx/ep8248e.c | 2 +-
> arch/powerpc/platforms/pasemi/gpio_mdio.c | 2 +-
> arch/powerpc/sysdev/fsl_soc.c | 5 +++--
> drivers/net/au1000_eth.c | 6 +++---
> drivers/net/bfin_mac.c | 2 +-
> drivers/net/cpmac.c | 5 ++---
> drivers/net/fec_mpc52xx.c | 2 +-
> drivers/net/fec_mpc52xx_phy.c | 2 +-
> drivers/net/fs_enet/fs_enet-main.c | 4 ++--
> drivers/net/fs_enet/mii-bitbang.c | 4 ++--
> drivers/net/fs_enet/mii-fec.c | 4 ++--
> drivers/net/gianfar_mii.c | 2 +-
> drivers/net/macb.c | 2 +-
> drivers/net/pasemi_mac.c | 2 +-
> drivers/net/phy/fixed.c | 2 +-
> drivers/net/sb1250-mac.c | 2 +-
> drivers/net/ucc_geth.c | 2 +-
> drivers/net/ucc_geth.h | 2 +-
> drivers/net/ucc_geth_mii.c | 2 +-
> include/linux/fsl_devices.h | 2 +-
> include/linux/phy.h | 12 ++++++++----
> 21 files changed, 36 insertions(+), 32 deletions(-)
applied
prev parent reply other threads:[~2008-04-12 9:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 0:38 [PATCH v2.6.26] phy: Change mii_bus id field to a string Andy Fleming
2008-04-12 9:01 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48007A67.3090806@pobox.com \
--to=jgarzik@pobox.com \
--cc=afleming@freescale.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).