Re: [Bugme-new] [Bug 10443] New: VLAN: link level multicasts addresses disappears...

[Patrick McHardy <kaber@trash.net>]

[-- Attachment #1: Type: text/plain, Size: 582 bytes --]

David Miller wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> Date: Fri, 11 Apr 2008 21:41:34 -0700
> 
>> There's a test case in the bugzilla report.
> 
> Could be fixed by:
> 
> commit 0ed21b321a13421e2dfeaa70a6c324e05e3e91e6
> Author: Patrick McHardy <kaber@trash.net>
> Date:   Wed Mar 26 00:15:17 2008 -0700
> 
>     [VLAN]: Don't copy ALLMULTI/PROMISC flags from underlying device

Either that patch or this one I guess:

[NET]: Messed multicast lists after dev_mc_sync/unsync

I'll go through our recent multicast fixes and check which
ones make sense for -stable.


[-- Attachment #2: x --]
[-- Type: text/plain, Size: 1184 bytes --]

commit 12aa343add3eced38a44bdb612b35fdf634d918c
Author: Jorge Boncompte [DTI2] <jorge@dti2.net>
Date:   Tue Feb 19 14:17:04 2008 -0800

    [NET]: Messed multicast lists after dev_mc_sync/unsync
    
    Commit a0a400d79e3dd7843e7e81baa3ef2957bdc292d0 ("[NET]: dev_mcast:
    add multicast list synchronization helpers") from you introduced a new
    field "da_synced" to struct dev_addr_list that is not properly
    initialized to 0. So when any of the current users (8021q, macvlan,
    mac80211) calls dev_mc_sync/unsync they mess the address list for both
    devices.
    
    The attached patch fixed it for me and avoid future problems.
    
    Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net>
    Signed-off-by: Patrick McHardy <kaber@trash.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/core/dev.c b/net/core/dev.c
index 6cfc123..9516105 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2900,7 +2900,7 @@ int __dev_addr_add(struct dev_addr_list **list, int *count,
 		}
 	}
 
-	da = kmalloc(sizeof(*da), GFP_ATOMIC);
+	da = kzalloc(sizeof(*da), GFP_ATOMIC);
 	if (da == NULL)
 		return -ENOMEM;
 	memcpy(da->da_addr, addr, alen);