From: Moni Shoua <monis@voltaire.com>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: netdev <netdev@vger.kernel.org>, Olga Stern <olgas@voltaire.com>,
Or Gerlitz <ogerlitz@voltaire.com>
Subject: Re: [PATCH]: net/bonding: Enable to change device type before enslaving
Date: Sun, 13 Apr 2008 17:09:20 +0300 [thread overview]
Message-ID: <48021410.5040806@voltaire.com> (raw)
In-Reply-To: <21771.1207860504@death>
> Does this mean that the automatic selection on first enslavement
> is no longer needed, and all setting of the type for IB devices must
> occur prior to first enslavement?
>
> Or is this more of a special case for some devices, and the
> automatic selection is still correct for most cases?
>
I think that the later is closer to the truth.
The goal is to modify the bonding module to work with IPoIB slaves but
with as small as possible changes to what already exists.
In details, the bonding net device device gets its type by ether_setup(),
which runs for all types of slaves and I don't see a way to change that.
However, bonding master for IPoIB slaves requires a different device type setting
before it comes up for some OSs (redhat 4 for instance). On other OSs I don't see the problem
and I guess that this is because master becomes up only after it has slaves.
next prev parent reply other threads:[~2008-04-13 14:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 15:09 [PATCH]: net/bonding: Enable to change device type before enslaving Moni Shoua
2008-04-10 20:48 ` Jay Vosburgh
2008-04-13 14:09 ` Moni Shoua [this message]
2008-04-16 19:27 ` Jay Vosburgh
2008-04-17 6:29 ` Moni Shoua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48021410.5040806@voltaire.com \
--to=monis@voltaire.com \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@voltaire.com \
--cc=olgas@voltaire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).