From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH 2/2] [POWERPC] UCC nodes cleanup Date: Mon, 14 Apr 2008 09:56:11 -0500 Message-ID: <4803708B.1070009@freescale.com> References: <20080311171045.GB4684@localhost.localdomain> <82E8E38A-C159-4C23-BDE8-086D4429F366@kernel.crashing.org> <20080411160654.GA25506@polina.dev.rtsoft.ru> <47FF9665.7020403@freescale.com> <20080411170657.GA15270@polina.dev.rtsoft.ru> <20080411171109.GA16119@polina.dev.rtsoft.ru> <47FF9BFE.5000201@freescale.com> <20080411172106.GA17786@polina.dev.rtsoft.ru> <20080411173100.GA20439@polina.dev.rtsoft.ru> <6B2293E0-BE5E-4C2E-9A48-4E91079A7422@kernel.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linuxppc-dev@ozlabs.org, Jeff Garzik , linux-serial@vger.kernel.org, netdev@vger.kernel.org To: Kumar Gala Return-path: In-Reply-To: <6B2293E0-BE5E-4C2E-9A48-4E91079A7422@kernel.crashing.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org List-Id: netdev.vger.kernel.org Kumar Gala wrote: > I say leave as you have it (UCC1 == cell-index = <1>). > > Changing it so cell-index = <0> is just more confusing w/regards to > the docs. I don't see anything in booting-without-of.txt that requires cell-index to start at 0, however, the only other device that starts at 1 is SATA. Even the SSI starts at 0: - cell-index : the SSI, <0> = SSI1, <1> = SSI2, and so on Although I don't want to make more work for Anton, my vote is to have cell-index start at 0. That is the convention. It's too late to fix SATA, but at least we can avoid making it worse. -- Timur Tabi Linux kernel developer at Freescale