From: Patrick McHardy <kaber@trash.net>
To: Auke Kok <auke-jan.h.kok@intel.com>
Cc: jeff@garzik.org, netdev@vger.kernel.org,
e1000-devel@lists.sourceforge.net
Subject: Re: [PATCH 3/5] e1000e: Allow TSO to trickle down to VLAN device
Date: Mon, 14 Apr 2008 19:11:23 +0200 [thread overview]
Message-ID: <4803903B.1020100@trash.net> (raw)
In-Reply-To: <20080414170609.23286.42880.stgit@localhost.localdomain>
Auke Kok wrote:
> Fix TSO over VLAN's by propagating settings to our VLAN devices.
>
> @@ -378,8 +381,21 @@ static int e1000_set_tso(struct net_device *netdev, u32 data)
> } else {
> netdev->features &= ~NETIF_F_TSO;
> netdev->features &= ~NETIF_F_TSO6;
> + /* disable TSO on all VLANs if they're present */
> + if (!adapter->vlgrp)
> + goto tso_out;
> + for (i = 0; i < VLAN_GROUP_ARRAY_LEN; i++) {
> + v_netdev = vlan_group_get_device(adapter->vlgrp, i);
> + if (!v_netdev)
> + continue;
> +
> + v_netdev->features &= ~NETIF_F_TSO;
> + v_netdev->features &= ~NETIF_F_TSO6;
> + vlan_group_set_device(adapter->vlgrp, i, v_netdev);
>
What exactly is this supposed to fix? If this simply wants
to propagate feature changes, I think it should use
netdev_feat_change and handle that within the VLAN code.
next prev parent reply other threads:[~2008-04-14 17:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-14 17:05 [PATCH 1/5] e1000e: cleanup several stats issues Auke Kok
2008-04-14 17:06 ` [PATCH 2/5] e1000e: Add interrupt moderation run-time ethtool interface Auke Kok
2008-04-14 19:24 ` Andi Kleen
2008-04-14 19:31 ` Rick Jones
2008-04-14 19:35 ` Jeff Garzik
2008-04-14 19:53 ` Andi Kleen
2008-04-14 20:09 ` Kok, Auke
2008-04-14 17:06 ` [PATCH 3/5] e1000e: Allow TSO to trickle down to VLAN device Auke Kok
2008-04-14 17:11 ` Patrick McHardy [this message]
2008-04-17 21:45 ` Kok, Auke
2008-04-21 14:24 ` Patrick McHardy
2008-04-22 7:46 ` Waskiewicz Jr, Peter P
2008-04-30 0:42 ` Waskiewicz Jr, Peter P
2008-04-30 6:54 ` Patrick McHardy
2008-04-30 6:56 ` Patrick McHardy
2008-04-14 17:06 ` [PATCH 4/5] e1000e: Fix HW Error on es2lan, ARP capture issue by BMC Auke Kok
2008-04-14 17:06 ` [PATCH 5/5] e1000e: lower ring minimum size to 64 Auke Kok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4803903B.1020100@trash.net \
--to=kaber@trash.net \
--cc=auke-jan.h.kok@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).