From: Arjan van de Ven <arjan@linux.intel.com>
To: NetDev <netdev@vger.kernel.org>
Subject: bugreport: The r8169.c driver is calling netif_receive_skb from hardirq and with interrupts off
Date: Mon, 14 Apr 2008 11:01:16 -0700 [thread overview]
Message-ID: <48039BEC.7070008@linux.intel.com> (raw)
The r8169.c driver is calling netif_receive_skb from hardirq and with interrupts off,
which seems to be invalid (the comments of netif_receive_skb) certainly say so.
The calltrace is like this:
packet_rcv
netif_receive_skb
rtl8168_rx_interrupt
rtl8168_interrupt
handle_IRQ_event
handle_fasteoi_irq
do_IRQ
Which triggers a warning in packet_rcv() since that does a local_bh_enable(),
which gives a WARN_ON if irqs are disabled (rightfully so it seems).
The code looks is in rtl8169_rx_interrupt() line 2832 and looks like
if (rtl8169_rx_vlan_skb(tp, desc, skb) < 0)
rtl8169_rx_skb(skb);
with
#define rtl8169_rx_skb netif_receive_skb
higher up in the file.
This is the 46th highest ranking warnon/oops report for 2.6.25-rc
Greetings,
Arjan van de Ven
next reply other threads:[~2008-04-14 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-14 18:01 Arjan van de Ven [this message]
2008-04-14 18:22 ` bugreport: The r8169.c driver is calling netif_receive_skb from hardirq and with interrupts off Stephen Hemminger
2008-04-14 18:24 ` Arjan van de Ven
2008-04-14 18:31 ` Stephen Hemminger
2008-04-15 16:34 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48039BEC.7070008@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).