From: Patrick McHardy <kaber@trash.net>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: David Miller <davem@davemloft.net>,
enrico@superclick.com, netdev@vger.kernel.org
Subject: Re: [PATCH][NET_SCHED] sch_api: fix qdisc_tree_decrease_qlen() loop
Date: Tue, 15 Apr 2008 14:37:32 +0200 [thread overview]
Message-ID: <4804A18C.2060200@trash.net> (raw)
In-Reply-To: <20080415053253.GA3920@ff.dom.local>
Jarek Poplawski wrote:
> On Mon, Apr 14, 2008 at 03:11:02PM -0700, David Miller wrote:
> ...
>>> Jarek Poplawski wrote:
> ...
>>>> After this fix qdisc_lookup() is omitted both for ingress and root
>>>> parents, but looking for root is only wasting a little time here...
>
> ...Actually, there is yet a possibility that somebody uses ffff:
> handle for a qdisc (not ingress), which could make here a little
> difference, so this place could be improved for this case (even
> with something like my earlier debugging patch in this thread,
> which BTW could be a safety for maybe some other quirks here),
> but it seems it would be better to discourage using this handle
> for anything but ingress.
I don't think we should do that, it would be preferable to
compare the entire handle instead of just the major to avoid
this.
next prev parent reply other threads:[~2008-04-15 12:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-11 18:37 HTB and ingress scheduler SMP Soft Lockup in 2.6.23-2.6.25-rc8 Enrico Demarin
2008-04-13 7:51 ` Patrick McHardy
2008-04-13 19:20 ` Enrico Demarin
2008-04-14 7:14 ` Patrick McHardy
2008-04-14 7:15 ` Patrick McHardy
2008-04-14 7:20 ` Patrick McHardy
2008-04-14 7:51 ` Patrick McHardy
2008-04-13 12:10 ` Jarek Poplawski
2008-04-14 20:26 ` [PATCH][NET_SCHED] sch_api: fix qdisc_tree_decrease_qlen() loop Jarek Poplawski
2008-04-14 20:28 ` Patrick McHardy
2008-04-14 22:11 ` David Miller
2008-04-15 5:32 ` Jarek Poplawski
2008-04-15 12:37 ` Patrick McHardy [this message]
2008-04-15 13:00 ` Jarek Poplawski
2008-04-15 13:09 ` Patrick McHardy
2008-04-15 13:10 ` Patrick McHardy
2008-04-15 17:41 ` Jarek Poplawski
2008-04-15 18:25 ` Jarek Poplawski
2008-04-15 19:29 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4804A18C.2060200@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=enrico@superclick.com \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).