From: Jeff Garzik <jeff@garzik.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: Andy Fleming <afleming@freescale.com>,
linux-mips@linux-mips.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/6] tc35815: Statistics cleanup
Date: Wed, 16 Apr 2008 20:54:11 -0400 [thread overview]
Message-ID: <48069FB3.1070404@garzik.org> (raw)
In-Reply-To: <20080413.001146.25909265.anemo@mba.ocn.ne.jp>
Atsushi Nemoto wrote:
> On Sat, 12 Apr 2008 05:00:49 -0400, Jeff Garzik <jeff@garzik.org> wrote:
>> applied 1-6
>
> Thanks.
>
> Could you apply this too, or hopufully fold into Andy Fleming's "phy:
> Change mii_bus id field to a string" patch (commit c69fedae) ?
>
> ------------------------------------------------------
> Subject: [PATCH] tc35815: build fix
>
> Fix build failure caused by Andy Fleming's "phy: Change mii_bus id
> field to a string" patch.
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> ---
> diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c
> index 744f11f..10e4e85 100644
> --- a/drivers/net/tc35815.c
> +++ b/drivers/net/tc35815.c
> @@ -766,7 +766,8 @@ static int tc_mii_init(struct net_device *dev)
> lp->mii_bus.name = "tc35815_mii_bus";
> lp->mii_bus.read = tc_mdio_read;
> lp->mii_bus.write = tc_mdio_write;
> - lp->mii_bus.id = (lp->pci_dev->bus->number << 8) | lp->pci_dev->devfn;
> + snprintf(lp->mii_bus.id, MII_BUS_ID_SIZE, "%x",
> + (lp->pci_dev->bus->number << 8) | lp->pci_dev->devfn);
> lp->mii_bus.priv = dev;
> lp->mii_bus.dev = &lp->pci_dev->dev;
> lp->mii_bus.irq = kmalloc(sizeof(int) * PHY_MAX_ADDR, GFP_KERNEL);
applied
prev parent reply other threads:[~2008-04-17 0:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 15:24 [PATCH 1/6] tc35815: Statistics cleanup Atsushi Nemoto
2008-04-12 9:00 ` Jeff Garzik
2008-04-12 15:11 ` Atsushi Nemoto
2008-04-17 0:54 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48069FB3.1070404@garzik.org \
--to=jeff@garzik.org \
--cc=afleming@freescale.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).