From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] cxgb3: Fix __must_check warning with dev_dbg. Date: Wed, 16 Apr 2008 20:54:18 -0400 Message-ID: <48069FBA.3040004@pobox.com> References: <12080540782177-git-send-email-dpn@isomerica.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: netdev@vger.kernel.org To: Dan Noe Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:57514 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751024AbYDQAyU (ORCPT ); Wed, 16 Apr 2008 20:54:20 -0400 In-Reply-To: <12080540782177-git-send-email-dpn@isomerica.net> Sender: netdev-owner@vger.kernel.org List-ID: Dan Noe wrote: > Fix the warning: > drivers/net/cxgb3/cxgb3_main.c: In function =E2=80=98offload_open=E2=80= =99: > drivers/net/cxgb3/cxgb3_main.c:936: warning: ignoring return value of > =E2=80=98sysfs_create_group=E2=80=99, declared with attribute warn_u= nused_result >=20 > Now the return value is checked; if sysfs_create_group() returns fail= ure, > a warning is printed using dev_dbg, and the code continues as before.= Use > of dev_dbg ensures printk is not needlessly included unless desired f= or > debugging. >=20 > Signed-off-by: Dan Noe > --- > drivers/net/cxgb3/cxgb3_main.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3= _main.c > index fd2e05b..05e5f59 100644 > --- a/drivers/net/cxgb3/cxgb3_main.c > +++ b/drivers/net/cxgb3/cxgb3_main.c > @@ -1014,8 +1014,8 @@ static int offload_open(struct net_device *dev) > adapter->port[0]->mtu : 0xffff); > init_smt(adapter); > =20 > - /* Never mind if the next step fails */ > - sysfs_create_group(&tdev->lldev->dev.kobj, &offload_attr_group); > + if (sysfs_create_group(&tdev->lldev->dev.kobj, &offload_attr_group)= ) > + dev_dbg(&dev->dev, "cannot create sysfs group\n"); > =20 applied