netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: bunk@kernel.org, mingo@elte.hu, linville@tuxdriver.com,
	tomas.winkler@intel.com, linux-kernel@vger.kernel.org,
	torvalds@linux-foundation.org, akpm@linux-foundation.org,
	netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
	mabbas@linux.intel.com, ischram@telenet.be, rjw@sisk.pl
Subject: Re: [build bug] nf_nat_proto_sctp.c:(.text+0x6d173): undefined reference to `crc32c_le'
Date: Mon, 21 Apr 2008 13:18:22 +0200	[thread overview]
Message-ID: <480C77FE.2040107@trash.net> (raw)
In-Reply-To: <20080421.015906.239470094.davem@davemloft.net>

David Miller wrote:
> From: Adrian Bunk <bunk@kernel.org>
> Date: Mon, 21 Apr 2008 11:44:02 +0300
> 
>> On Sun, Apr 20, 2008 at 11:53:54PM -0700, David Miller wrote:
>>> From: Ingo Molnar <mingo@elte.hu>
>>> Date: Mon, 21 Apr 2008 08:22:44 +0200
>>>
>>>>   net/built-in.o: In function `sctp_manip_pkt':
>>>>   nf_nat_proto_sctp.c:(.text+0x6d173): undefined reference to `crc32c_le'
>>>>   nf_nat_proto_sctp.c:(.text+0x6d180): undefined reference to `crc32c_le'
>>>>   nf_nat_proto_sctp.c:(.text+0x6d196): undefined reference to `crc32c_le'
>>>>   nf_nat_proto_sctp.c:(.text+0x6d1c6): undefined reference to `crc32c_le'
>>>>
>>>>   http://redhat.com/~mingo/misc/config-Mon_Apr_21_01_52_14_CEST_2008.bad
>>> Thanks for your report Ingo.
>>>
>>> Patrick, I'm not so sure how to fix this, or even what's wrong.
>>>
>>> NF_NAT_PROTO_SCTP does a proper select on LIBCRC32C, but somehow
>>> NF_NAT_PROTO_SCTP=y and LIBCRC32C=m.
>>> ...
>> You added the select on Saturday after Pete Clements reported the same 
>> issue.
>>
>> The select is not yet in Linus' tree.
> 
> Thanks for catching that Adrian.

I've verified that Saturday's patch results in a correct looking
config, with

CONFIG_NF_NAT_PROTO_SCTP=y
CONFIG_LIBCRC32C=y


      reply	other threads:[~2008-04-21 11:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-21  6:22 [build bug] nf_nat_proto_sctp.c:(.text+0x6d173): undefined reference to `crc32c_le' Ingo Molnar
2008-04-21  6:53 ` David Miller
2008-04-21  8:44   ` Adrian Bunk
2008-04-21  8:59     ` David Miller
2008-04-21 11:18       ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=480C77FE.2040107@trash.net \
    --to=kaber@trash.net \
    --cc=akpm@linux-foundation.org \
    --cc=bunk@kernel.org \
    --cc=davem@davemloft.net \
    --cc=ischram@telenet.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mabbas@linux.intel.com \
    --cc=mingo@elte.hu \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=tomas.winkler@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).