From: Patrick McHardy <kaber@trash.net>
To: hadi@cyberus.ca
Cc: Stephen Hemminger <shemminger@vyatta.com>, netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] [TC/U32] Infrastructure for pretty printing
Date: Mon, 21 Apr 2008 13:52:38 +0200 [thread overview]
Message-ID: <480C8006.3060708@trash.net> (raw)
In-Reply-To: <1208702964.12249.57.camel@localhost>
jamal wrote:
> case 0x0f000000:
> - fprintf(f, "\n ihl %u", ntohl(key->val) >> 24);
> + fprintf(f, "\n match IP ihl %u", ntohl(key->val) >> 24);
> return;
> case 0x00ff0000:
> - fprintf(f, "\n dsfield %#x", ntohl(key->val) >> 16);
> + fprintf(f, "\n match IP dsfield %#x", ntohl(key->val) >> 16);
> return;
> }
So far the dump output can be cut-and-pasted and is
properly parsed again (useful for example for deletion).
Does that still work with pretty printing?
next prev parent reply other threads:[~2008-04-21 11:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-20 14:49 [PATCH 3/3] [TC/U32] Infrastructure for pretty printing jamal
2008-04-21 11:52 ` Patrick McHardy [this message]
2008-04-21 13:23 ` jamal
2008-04-21 13:29 ` Patrick McHardy
2008-04-21 13:58 ` jamal
2008-04-21 14:15 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480C8006.3060708@trash.net \
--to=kaber@trash.net \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).